<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26322">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/device: Remove space after sizeof<br><br>Change-Id: Ic8b77c78739badbea398053944484a55f715d03d<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/device/device_util.c<br>M src/device/oprom/x86emu/debug.c<br>2 files changed, 17 insertions(+), 17 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/26322/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/device/device_util.c b/src/device/device_util.c</span><br><span>index aad3b4b..3f65b67 100644</span><br><span>--- a/src/device/device_util.c</span><br><span>+++ b/src/device/device_util.c</span><br><span>@@ -288,60 +288,60 @@</span><br><span> memcpy(buffer, "Root Device", 12);</span><br><span> break;</span><br><span> case DEVICE_PATH_PCI:</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(buffer, sizeof (buffer),</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buffer, sizeof(buffer),</span><br><span> "PCI: %02x:%02x.%01x",</span><br><span> dev->bus->secondary,</span><br><span> PCI_SLOT(dev->path.pci.devfn),</span><br><span> PCI_FUNC(dev->path.pci.devfn));</span><br><span> break;</span><br><span> case DEVICE_PATH_PNP:</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(buffer, sizeof (buffer), "PNP: %04x.%01x",</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buffer, sizeof(buffer), "PNP: %04x.%01x",</span><br><span> dev->path.pnp.port, dev->path.pnp.device);</span><br><span> break;</span><br><span> case DEVICE_PATH_I2C:</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(buffer, sizeof (buffer), "I2C: %02x:%02x",</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buffer, sizeof(buffer), "I2C: %02x:%02x",</span><br><span> dev->bus->secondary,</span><br><span> dev->path.i2c.device);</span><br><span> break;</span><br><span> case DEVICE_PATH_APIC:</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(buffer, sizeof (buffer), "APIC: %02x",</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buffer, sizeof(buffer), "APIC: %02x",</span><br><span> dev->path.apic.apic_id);</span><br><span> break;</span><br><span> case DEVICE_PATH_IOAPIC:</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(buffer, sizeof (buffer), "IOAPIC: %02x",</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buffer, sizeof(buffer), "IOAPIC: %02x",</span><br><span> dev->path.ioapic.ioapic_id);</span><br><span> break;</span><br><span> case DEVICE_PATH_DOMAIN:</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(buffer, sizeof (buffer), "DOMAIN: %04x",</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buffer, sizeof(buffer), "DOMAIN: %04x",</span><br><span> dev->path.domain.domain);</span><br><span> break;</span><br><span> case DEVICE_PATH_CPU_CLUSTER:</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(buffer, sizeof (buffer), "CPU_CLUSTER: %01x",</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buffer, sizeof(buffer), "CPU_CLUSTER: %01x",</span><br><span> dev->path.cpu_cluster.cluster);</span><br><span> break;</span><br><span> case DEVICE_PATH_CPU:</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(buffer, sizeof (buffer),</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buffer, sizeof(buffer),</span><br><span> "CPU: %02x", dev->path.cpu.id);</span><br><span> break;</span><br><span> case DEVICE_PATH_CPU_BUS:</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(buffer, sizeof (buffer),</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buffer, sizeof(buffer),</span><br><span> "CPU_BUS: %02x", dev->path.cpu_bus.id);</span><br><span> break;</span><br><span> case DEVICE_PATH_GENERIC:</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(buffer, sizeof (buffer),</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buffer, sizeof(buffer),</span><br><span> "GENERIC: %d.%d", dev->path.generic.id,</span><br><span> dev->path.generic.subid);</span><br><span> break;</span><br><span> case DEVICE_PATH_SPI:</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(buffer, sizeof (buffer), "SPI: %02x",</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buffer, sizeof(buffer), "SPI: %02x",</span><br><span> dev->path.spi.cs);</span><br><span> break;</span><br><span> case DEVICE_PATH_USB:</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(buffer, sizeof (buffer), "USB%u port %u",</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buffer, sizeof(buffer), "USB%u port %u",</span><br><span> dev->path.usb.port_type, dev->path.usb.port_id);</span><br><span> break;</span><br><span> case DEVICE_PATH_MMIO:</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(buffer, sizeof (buffer), "MMIO: %08x",</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buffer, sizeof(buffer), "MMIO: %08x",</span><br><span> dev->path.mmio.addr);</span><br><span> break;</span><br><span> default:</span><br><span>@@ -366,7 +366,7 @@</span><br><span> const char *bus_path(struct bus *bus)</span><br><span> {</span><br><span> static char buffer[BUS_PATH_MAX];</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(buffer, sizeof (buffer),</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buffer, sizeof(buffer),</span><br><span> "%s,%d", dev_path(bus->dev), bus->link_num);</span><br><span> return buffer;</span><br><span> }</span><br><span>@@ -670,7 +670,7 @@</span><br><span> const char *resource_type(struct resource *resource)</span><br><span> {</span><br><span> static char buffer[RESOURCE_TYPE_MAX];</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(buffer, sizeof (buffer), "%s%s%s%s",</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buffer, sizeof(buffer), "%s%s%s%s",</span><br><span> ((resource->flags & IORESOURCE_READONLY) ? "ro" : ""),</span><br><span> ((resource->flags & IORESOURCE_PREFETCH) ? "pref" : ""),</span><br><span> ((resource->flags == 0) ? "unused" :</span><br><span>@@ -703,7 +703,7 @@</span><br><span> buf[0] = '\0';</span><br><span> </span><br><span> if (resource->flags & IORESOURCE_PCI_BRIDGE) {</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(buf, sizeof (buf),</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buf, sizeof(buf),</span><br><span> "bus %02x ", dev->link_list->secondary);</span><br><span> }</span><br><span> printk(BIOS_DEBUG, "%s %02lx <- [0x%010llx - 0x%010llx] size 0x%08llx "</span><br><span>diff --git a/src/device/oprom/x86emu/debug.c b/src/device/oprom/x86emu/debug.c</span><br><span>index 9e216e9..ab55198 100644</span><br><span>--- a/src/device/oprom/x86emu/debug.c</span><br><span>+++ b/src/device/oprom/x86emu/debug.c</span><br><span>@@ -170,7 +170,7 @@</span><br><span> void x86emu_decode_printf2 (const char *x, int y)</span><br><span> {</span><br><span> char temp[100];</span><br><span style="color: hsl(0, 100%, 40%);">- snprintf(temp, sizeof (temp), x,y);</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(temp, sizeof(temp), x,y);</span><br><span> strcpy(M.x86.decoded_buf+M.x86.enc_str_pos,temp);</span><br><span> M.x86.enc_str_pos += strlen(temp);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26322">change 26322</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26322"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic8b77c78739badbea398053944484a55f715d03d </div>
<div style="display:none"> Gerrit-Change-Number: 26322 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>