[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nocturne: deassert audio amp reset
Nick Vaccaro (Code Review)
gerrit at coreboot.org
Wed May 16 11:56:03 CEST 2018
Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/26317
Change subject: mb/google/poppy/variants/nocturne: deassert audio amp reset
......................................................................
mb/google/poppy/variants/nocturne: deassert audio amp reset
Drive SPKR_RST_L (GPP_A19) high at boot to take audio amps out of
reset.
BUG=b:78122599
BRANCH=none
TEST="emerge-nocturne coreboot chromeos-bootimage", boot to kernel,
and verify sound works via "aplay /dev/random"
Change-Id: Ia49931f2dc7802edc8a46114b081e4a96eeee604
Signed-off-by: Nick Vaccaro <nvaccaro at google.com>
---
M src/mainboard/google/poppy/variants/nocturne/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/26317/1
diff --git a/src/mainboard/google/poppy/variants/nocturne/gpio.c b/src/mainboard/google/poppy/variants/nocturne/gpio.c
index 0e4852c..ffb396b 100644
--- a/src/mainboard/google/poppy/variants/nocturne/gpio.c
+++ b/src/mainboard/google/poppy/variants/nocturne/gpio.c
@@ -53,7 +53,7 @@
/* A18 : ISH_GP0 ==> ISH_GP0 */
PAD_CFG_NC(GPP_A18),
/* A19 : SPKR_RST_L */
- PAD_CFG_GPO(GPP_A19, 0, PLTRST),
+ PAD_CFG_GPO(GPP_A19, 1, PLTRST),
/* A20 : ISH_GP2 ==> ISH_UART0_RXD */
PAD_CFG_NC(GPP_A20),
/* A21 : ISH_GP3 */
--
To view, visit https://review.coreboot.org/26317
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia49931f2dc7802edc8a46114b081e4a96eeee604
Gerrit-Change-Number: 26317
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180516/84398bd5/attachment-0001.html>
More information about the coreboot-gerrit
mailing list