<p>Nick Vaccaro has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26317">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nocturne: deassert audio amp reset<br><br>Drive SPKR_RST_L (GPP_A19) high at boot to take audio amps out of<br>reset.<br><br>BUG=b:78122599<br>BRANCH=none<br>TEST="emerge-nocturne coreboot chromeos-bootimage", boot to kernel,<br>and verify sound works via "aplay /dev/random"<br><br>Change-Id: Ia49931f2dc7802edc8a46114b081e4a96eeee604<br>Signed-off-by: Nick Vaccaro <nvaccaro@google.com><br>---<br>M src/mainboard/google/poppy/variants/nocturne/gpio.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/26317/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/gpio.c b/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>index 0e4852c..ffb396b 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>@@ -53,7 +53,7 @@</span><br><span>       /* A18 : ISH_GP0 ==> ISH_GP0 */</span><br><span>   PAD_CFG_NC(GPP_A18),</span><br><span>         /* A19 : SPKR_RST_L */</span><br><span style="color: hsl(0, 100%, 40%);">-  PAD_CFG_GPO(GPP_A19, 0, PLTRST),</span><br><span style="color: hsl(120, 100%, 40%);">+      PAD_CFG_GPO(GPP_A19, 1, PLTRST),</span><br><span>     /* A20 : ISH_GP2 ==> ISH_UART0_RXD */</span><br><span>     PAD_CFG_NC(GPP_A20),</span><br><span>         /* A21 : ISH_GP3 */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26317">change 26317</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26317"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia49931f2dc7802edc8a46114b081e4a96eeee604 </div>
<div style="display:none"> Gerrit-Change-Number: 26317 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com> </div>