[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nocturne: add touchscreen register info
Nick Vaccaro (Code Review)
gerrit at coreboot.org
Wed May 16 11:56:03 CEST 2018
Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/26316
Change subject: mb/google/poppy/variants/nocturne: add touchscreen register info
......................................................................
mb/google/poppy/variants/nocturne: add touchscreen register info
- add register information for touchscreen WCOM digitizer
- enable EN_PP3300_DX_TOUCHSCREEN (GPP_C22) to power touchscreen
BUG=b:78122599
BRANCH=none
TEST="emerge-nocturne coreboot chromeos-bootimage" and verify
touchscreen on Nocturne board works.
Change-Id: I9790a930e8ed2748d568ce58c931ce34b3e22007
Signed-off-by: Nick Vaccaro <nvaccaro at google.com>
---
M src/mainboard/google/poppy/variants/nocturne/devicetree.cb
M src/mainboard/google/poppy/variants/nocturne/gpio.c
2 files changed, 11 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/26316/1
diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
index ee4e1c7..04e9b0c 100644
--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
@@ -246,7 +246,16 @@
device pci 14.0 on end # USB xHCI
device pci 14.1 on end # USB xDCI (OTG)
device pci 14.2 on end # Thermal Subsystem
- device pci 15.0 on end # I2C #0 - Touchscreen
+ device pci 15.0 on
+ chip drivers/i2c/hid
+ register "generic.hid" = ""WCOM50C1""
+ register "generic.desc" = ""WCOM Digitizer""
+ register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E7_IRQ)"
+ register "generic.speed" = "I2C_SPEED_FAST_PLUS"
+ register "hid_desc_reg_offset" = "0x1"
+ device i2c 0a on end
+ end
+ end # I2C #0 - Touchscreen
device pci 15.1 on end # I2C #1 - Trackpad
device pci 15.2 off end # I2C #2
device pci 15.3 on end # I2C #3 - Camera
diff --git a/src/mainboard/google/poppy/variants/nocturne/gpio.c b/src/mainboard/google/poppy/variants/nocturne/gpio.c
index da3adb3..0e4852c 100644
--- a/src/mainboard/google/poppy/variants/nocturne/gpio.c
+++ b/src/mainboard/google/poppy/variants/nocturne/gpio.c
@@ -157,7 +157,7 @@
/* C21 : UART2_TXD ==> PCHTX_SERVORX_UART */
PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1),
/* C22 : UART2_RTS# ==> EN_PP3300_DX_TOUCHSCREEN */
- PAD_CFG_GPO(GPP_C22, 0, DEEP),
+ PAD_CFG_GPO(GPP_C22, 1, DEEP),
/* C23 : UART2_CTS# ==> PCH_WP_OD */
PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, 20K_PU, DEEP),
--
To view, visit https://review.coreboot.org/26316
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9790a930e8ed2748d568ce58c931ce34b3e22007
Gerrit-Change-Number: 26316
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180516/25de2c4a/attachment-0001.html>
More information about the coreboot-gerrit
mailing list