<p>Nick Vaccaro has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26316">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nocturne: add touchscreen register info<br><br>- add register information for touchscreen WCOM digitizer<br>- enable EN_PP3300_DX_TOUCHSCREEN (GPP_C22) to power touchscreen<br><br>BUG=b:78122599<br>BRANCH=none<br>TEST="emerge-nocturne coreboot chromeos-bootimage" and verify<br>touchscreen on Nocturne board works.<br><br>Change-Id: I9790a930e8ed2748d568ce58c931ce34b3e22007<br>Signed-off-by: Nick Vaccaro <nvaccaro@google.com><br>---<br>M src/mainboard/google/poppy/variants/nocturne/devicetree.cb<br>M src/mainboard/google/poppy/variants/nocturne/gpio.c<br>2 files changed, 11 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/26316/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>index ee4e1c7..04e9b0c 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>@@ -246,7 +246,16 @@</span><br><span>                 device pci 14.0 on  end # USB xHCI</span><br><span>           device pci 14.1 on  end # USB xDCI (OTG)</span><br><span>             device pci 14.2 on  end # Thermal Subsystem</span><br><span style="color: hsl(0, 100%, 40%);">-             device pci 15.0 on  end # I2C #0 - Touchscreen</span><br><span style="color: hsl(120, 100%, 40%);">+                device pci 15.0 on</span><br><span style="color: hsl(120, 100%, 40%);">+                    chip drivers/i2c/hid</span><br><span style="color: hsl(120, 100%, 40%);">+                          register "generic.hid" = ""WCOM50C1""</span><br><span style="color: hsl(120, 100%, 40%);">+                           register "generic.desc" = ""WCOM Digitizer""</span><br><span style="color: hsl(120, 100%, 40%);">+                            register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E7_IRQ)"</span><br><span style="color: hsl(120, 100%, 40%);">+                         register "generic.speed" = "I2C_SPEED_FAST_PLUS"</span><br><span style="color: hsl(120, 100%, 40%);">+                          register "hid_desc_reg_offset" = "0x1"</span><br><span style="color: hsl(120, 100%, 40%);">+                            device i2c 0a on end</span><br><span style="color: hsl(120, 100%, 40%);">+                  end</span><br><span style="color: hsl(120, 100%, 40%);">+           end # I2C #0 - Touchscreen</span><br><span>           device pci 15.1 on  end # I2C #1 - Trackpad</span><br><span>          device pci 15.2 off end # I2C #2</span><br><span>             device pci 15.3 on  end # I2C #3 - Camera</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/gpio.c b/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>index da3adb3..0e4852c 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>@@ -157,7 +157,7 @@</span><br><span>     /* C21 : UART2_TXD ==> PCHTX_SERVORX_UART */</span><br><span>      PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1),</span><br><span>        /* C22 : UART2_RTS# ==> EN_PP3300_DX_TOUCHSCREEN */</span><br><span style="color: hsl(0, 100%, 40%);">-  PAD_CFG_GPO(GPP_C22, 0, DEEP),</span><br><span style="color: hsl(120, 100%, 40%);">+        PAD_CFG_GPO(GPP_C22, 1, DEEP),</span><br><span>       /* C23 : UART2_CTS# ==> PCH_WP_OD */</span><br><span>      PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, 20K_PU, DEEP),</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26316">change 26316</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26316"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I9790a930e8ed2748d568ce58c931ce34b3e22007 </div>
<div style="display:none"> Gerrit-Change-Number: 26316 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com> </div>