[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge: Use dev_find_path() over dev_find_slot()

Nico Huber (Code Review) gerrit at coreboot.org
Tue May 15 14:22:51 CEST 2018


Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26295


Change subject: nb/intel/sandybridge: Use dev_find_path() over dev_find_slot()
......................................................................

nb/intel/sandybridge: Use dev_find_path() over dev_find_slot()

In romstage, dev_find_slot() may return the wrong device as all
secondary bus numbers are zero.

Change-Id: I1a63e8577037fe4890bc202bf123d373711c6b06
Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
M src/northbridge/intel/sandybridge/raminit_common.c
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/26295/1

diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c
index 5f6753f..4ab9186 100644
--- a/src/northbridge/intel/sandybridge/raminit_common.c
+++ b/src/northbridge/intel/sandybridge/raminit_common.c
@@ -388,7 +388,8 @@
 	const struct device *dev;
 	const struct northbridge_intel_sandybridge_config *cfg = NULL;
 
-	dev = dev_find_slot(0, HOST_BRIDGE);
+	/* We know, there is only a single domain supported by the chipset. */
+	dev = dev_find_path(NULL, DEVICE_PATH_DOMAIN);
 	if (dev)
 		cfg = dev->chip_info;
 
@@ -454,7 +455,8 @@
 	const struct device *dev;
 	const struct northbridge_intel_sandybridge_config *cfg = NULL;
 
-	dev = dev_find_slot(0, HOST_BRIDGE);
+	/* We know, there is only a single domain supported by the chipset. */
+	dev = dev_find_path(NULL, DEVICE_PATH_DOMAIN);
 	if (dev)
 		cfg = dev->chip_info;
 

-- 
To view, visit https://review.coreboot.org/26295
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a63e8577037fe4890bc202bf123d373711c6b06
Gerrit-Change-Number: 26295
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180515/63d349fa/attachment-0001.html>


More information about the coreboot-gerrit mailing list