<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26295">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/sandybridge: Use dev_find_path() over dev_find_slot()<br><br>In romstage, dev_find_slot() may return the wrong device as all<br>secondary bus numbers are zero.<br><br>Change-Id: I1a63e8577037fe4890bc202bf123d373711c6b06<br>Signed-off-by: Nico Huber <nico.huber@secunet.com><br>---<br>M src/northbridge/intel/sandybridge/raminit_common.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/26295/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c</span><br><span>index 5f6753f..4ab9186 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/raminit_common.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/raminit_common.c</span><br><span>@@ -388,7 +388,8 @@</span><br><span>       const struct device *dev;</span><br><span>    const struct northbridge_intel_sandybridge_config *cfg = NULL;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      dev = dev_find_slot(0, HOST_BRIDGE);</span><br><span style="color: hsl(120, 100%, 40%);">+  /* We know, there is only a single domain supported by the chipset. */</span><br><span style="color: hsl(120, 100%, 40%);">+        dev = dev_find_path(NULL, DEVICE_PATH_DOMAIN);</span><br><span>       if (dev)</span><br><span>             cfg = dev->chip_info;</span><br><span> </span><br><span>@@ -454,7 +455,8 @@</span><br><span>   const struct device *dev;</span><br><span>    const struct northbridge_intel_sandybridge_config *cfg = NULL;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      dev = dev_find_slot(0, HOST_BRIDGE);</span><br><span style="color: hsl(120, 100%, 40%);">+  /* We know, there is only a single domain supported by the chipset. */</span><br><span style="color: hsl(120, 100%, 40%);">+        dev = dev_find_path(NULL, DEVICE_PATH_DOMAIN);</span><br><span>       if (dev)</span><br><span>             cfg = dev->chip_info;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26295">change 26295</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26295"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1a63e8577037fe4890bc202bf123d373711c6b06 </div>
<div style="display:none"> Gerrit-Change-Number: 26295 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>