[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Fix AP timeout issue while executing sgx_configure

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/26286


Change subject: soc/intel/skylake: Fix AP timeout issue while executing sgx_configure
......................................................................

soc/intel/skylake: Fix AP timeout issue while executing sgx_configure

Increase AP timeout limit for sgx_configure function. As per debug log
sgx_configure was not successful on all cores with given timeout value.

TEST=Ensures no timeout error in AP function execution.

Change-Id: Ia83f7a7eb6cd6c4808d55febfebe32724a633173
Signed-off-by: Subrata Banik <subrata.banik at intel.com>
---
M src/soc/intel/skylake/cpu.c
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/26286/1

diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c
index 7f19dac..5d14f5b 100644
--- a/src/soc/intel/skylake/cpu.c
+++ b/src/soc/intel/skylake/cpu.c
@@ -48,6 +48,7 @@
 #include <soc/ramstage.h>
 #include <soc/smm.h>
 #include <soc/systemagent.h>
+#include <timer.h>
 
 /* Convert time in seconds to POWER_LIMIT_1_TIME MSR value */
 static const u8 power_limit_time_sec_to_msr[] = {
@@ -477,9 +478,9 @@
 	smm_lock();
 #endif
 
-	mp_run_on_all_cpus(vmx_configure, NULL, 2000);
+	mp_run_on_all_cpus(vmx_configure, NULL, 2 * USECS_PER_MSEC);
 
-	mp_run_on_all_cpus(sgx_configure, NULL, 2000);
+	mp_run_on_all_cpus(sgx_configure, NULL, 12 * USECS_PER_MSEC);
 }
 
 static const struct mp_ops mp_ops = {

-- 
To view, visit https://review.coreboot.org/26286
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia83f7a7eb6cd6c4808d55febfebe32724a633173
Gerrit-Change-Number: 26286
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180515/0472b8a0/attachment-0001.html>