<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26286">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: Fix AP timeout issue while executing sgx_configure<br><br>Increase AP timeout limit for sgx_configure function. As per debug log<br>sgx_configure was not successful on all cores with given timeout value.<br><br>TEST=Ensures no timeout error in AP function execution.<br><br>Change-Id: Ia83f7a7eb6cd6c4808d55febfebe32724a633173<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/soc/intel/skylake/cpu.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/26286/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c</span><br><span>index 7f19dac..5d14f5b 100644</span><br><span>--- a/src/soc/intel/skylake/cpu.c</span><br><span>+++ b/src/soc/intel/skylake/cpu.c</span><br><span>@@ -48,6 +48,7 @@</span><br><span> #include <soc/ramstage.h></span><br><span> #include <soc/smm.h></span><br><span> #include <soc/systemagent.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <timer.h></span><br><span> </span><br><span> /* Convert time in seconds to POWER_LIMIT_1_TIME MSR value */</span><br><span> static const u8 power_limit_time_sec_to_msr[] = {</span><br><span>@@ -477,9 +478,9 @@</span><br><span>   smm_lock();</span><br><span> #endif</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       mp_run_on_all_cpus(vmx_configure, NULL, 2000);</span><br><span style="color: hsl(120, 100%, 40%);">+        mp_run_on_all_cpus(vmx_configure, NULL, 2 * USECS_PER_MSEC);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        mp_run_on_all_cpus(sgx_configure, NULL, 2000);</span><br><span style="color: hsl(120, 100%, 40%);">+        mp_run_on_all_cpus(sgx_configure, NULL, 12 * USECS_PER_MSEC);</span><br><span> }</span><br><span> </span><br><span> static const struct mp_ops mp_ops = {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26286">change 26286</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26286"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia83f7a7eb6cd6c4808d55febfebe32724a633173 </div>
<div style="display:none"> Gerrit-Change-Number: 26286 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>