[coreboot-gerrit] Change in coreboot[master]: atlas ish: ish configuration

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/26277 )

Change subject: atlas ish: ish configuration
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/26277/2/src/mainboard/google/poppy/variants/atlas/gpio.c
File src/mainboard/google/poppy/variants/atlas/gpio.c:

https://review.coreboot.org/#/c/26277/2/src/mainboard/google/poppy/variants/atlas/gpio.c@60
PS2, Line 60: PAD_CFG_NC
wouldn't we still need to see the trackpad IRQ
in the non-ISH case?
A19 for IRQ and A23 for wake?



-- 
To view, visit https://review.coreboot.org/26277
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I606705bed4030469b71ef630cfdd974601a4f899
Gerrit-Change-Number: 26277
Gerrit-PatchSet: 2
Gerrit-Owner: Li1 Feng <li1.feng at intel.com>
Gerrit-Reviewer: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: caveh jalali <caveh at chromium.org>
Gerrit-Comment-Date: Tue, 15 May 2018 03:49:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180515/2bd058a2/attachment.html>