<p><a href="https://review.coreboot.org/26277">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26277/2/src/mainboard/google/poppy/variants/atlas/gpio.c">File src/mainboard/google/poppy/variants/atlas/gpio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26277/2/src/mainboard/google/poppy/variants/atlas/gpio.c@60">Patch Set #2, Line 60:</a> <code style="font-family:monospace,monospace">PAD_CFG_NC</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">wouldn't we still need to see the trackpad IRQ<br>in the non-ISH case?<br>A19 for IRQ and A23 for wake?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26277">change 26277</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26277"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I606705bed4030469b71ef630cfdd974601a4f899 </div>
<div style="display:none"> Gerrit-Change-Number: 26277 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Li1 Feng <li1.feng@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Caveh Jalali <caveh@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Hannah Williams <hannah.williams@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Reviewer: caveh jalali <caveh@chromium.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 15 May 2018 03:49:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>