[coreboot-gerrit] Change in coreboot[master]: sb/intel/i82801bx: Get rid of device_t

Elyes HAOUAS (Code Review) gerrit at coreboot.org
Sun May 13 13:32:05 CEST 2018


Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26253


Change subject: sb/intel/i82801bx: Get rid of device_t
......................................................................

sb/intel/i82801bx: Get rid of device_t

Use of device_t has been abandoned in ramstage.

Change-Id: I661b2435d9f0306b246a3e89aac24eb30c959085
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/southbridge/intel/i82801bx/i82801bx.c
M src/southbridge/intel/i82801bx/i82801bx.h
M src/southbridge/intel/i82801bx/lpc.c
M src/southbridge/intel/i82801bx/smbus.c
M src/southbridge/intel/i82801bx/watchdog.c
5 files changed, 10 insertions(+), 10 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/26253/1

diff --git a/src/southbridge/intel/i82801bx/i82801bx.c b/src/southbridge/intel/i82801bx/i82801bx.c
index 99d630f..163b6f4 100644
--- a/src/southbridge/intel/i82801bx/i82801bx.c
+++ b/src/southbridge/intel/i82801bx/i82801bx.c
@@ -21,10 +21,10 @@
 #include <device/pci.h>
 #include "i82801bx.h"
 
-void i82801bx_enable(device_t dev)
+void i82801bx_enable(struct device *dev)
 {
 	u16 reg16, index;
-	device_t lpc_dev;
+	struct device *lpc_dev;
 
 	/* Search for the 82801BA/BAM LPC device (D31:F0) on PCI bus 0. */
 	lpc_dev = dev_find_slot(0, PCI_DEVFN(0x1f, 0));
diff --git a/src/southbridge/intel/i82801bx/i82801bx.h b/src/southbridge/intel/i82801bx/i82801bx.h
index 3ecfe72..7a64979 100644
--- a/src/southbridge/intel/i82801bx/i82801bx.h
+++ b/src/southbridge/intel/i82801bx/i82801bx.h
@@ -19,7 +19,7 @@
 
 #if !defined(__PRE_RAM__)
 #include "chip.h"
-extern void i82801bx_enable(device_t dev);
+extern void i82801bx_enable(struct device *dev);
 #endif
 
 #if defined(__PRE_RAM__)
diff --git a/src/southbridge/intel/i82801bx/lpc.c b/src/southbridge/intel/i82801bx/lpc.c
index 0d8ebe0..4fbc004 100644
--- a/src/southbridge/intel/i82801bx/lpc.c
+++ b/src/southbridge/intel/i82801bx/lpc.c
@@ -119,7 +119,7 @@
 	/* TODO: Explain/#define the real meaning of these magic numbers. */
 }
 
-static void i82801bx_pirq_init(device_t dev, uint16_t ich_model)
+static void i82801bx_pirq_init(struct device *dev, uint16_t ich_model)
 {
 	u8 reg8;
 	config_t *config = dev->chip_info;
@@ -150,7 +150,7 @@
 	pci_write_config8(dev, PIRQH_ROUT, reg8);
 }
 
-static void i82801bx_power_options(device_t dev)
+static void i82801bx_power_options(struct device *dev)
 {
 	uint8_t byte;
 	int pwr_on = -1;
@@ -180,7 +180,7 @@
 	}
 }
 
-static void gpio_init(device_t dev)
+static void gpio_init(struct device *dev)
 {
 	/* Set the value for GPIO base address register and enable GPIO. */
 	pci_write_config32(dev, GPIO_BASE, (GPIO_BASE_ADDR | 1));
@@ -222,7 +222,7 @@
 	pci_write_config16(dev, PCI_DMA_CFG, reg16);
 }
 
-static void i82801bx_lpc_decode_en(device_t dev, uint16_t ich_model)
+static void i82801bx_lpc_decode_en(struct device *dev, uint16_t ich_model)
 {
 	/* Decode 0x3F8-0x3FF (COM1) for COMA port, 0x2F8-0x2FF (COM2) for COMB.
 	 * LPT decode defaults to 0x378-0x37F and 0x778-0x77F.
@@ -269,7 +269,7 @@
 	i82801bx_lpc_decode_en(dev, ich_model);
 }
 
-static void i82801bx_lpc_read_resources(device_t dev)
+static void i82801bx_lpc_read_resources(struct device *dev)
 {
 	struct resource *res;
 
diff --git a/src/southbridge/intel/i82801bx/smbus.c b/src/southbridge/intel/i82801bx/smbus.c
index 01e8c37..90975cd 100644
--- a/src/southbridge/intel/i82801bx/smbus.c
+++ b/src/southbridge/intel/i82801bx/smbus.c
@@ -22,7 +22,7 @@
 #include <southbridge/intel/common/smbus.h>
 #include "i82801bx.h"
 
-static int lsmbus_read_byte(device_t dev, u8 address)
+static int lsmbus_read_byte(struct device *dev, u8 address)
 {
 	u16 device;
 	struct resource *res;
diff --git a/src/southbridge/intel/i82801bx/watchdog.c b/src/southbridge/intel/i82801bx/watchdog.c
index 60a7b57..d0af76c 100644
--- a/src/southbridge/intel/i82801bx/watchdog.c
+++ b/src/southbridge/intel/i82801bx/watchdog.c
@@ -24,7 +24,7 @@
 
 void watchdog_off(void)
 {
-	device_t dev;
+	struct device *dev;
 	unsigned long value, base;
 
 	/* Turn off the ICH5 watchdog. */

-- 
To view, visit https://review.coreboot.org/26253
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I661b2435d9f0306b246a3e89aac24eb30c959085
Gerrit-Change-Number: 26253
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180513/e8fbdfdf/attachment.html>


More information about the coreboot-gerrit mailing list