[coreboot-gerrit] Change in coreboot[master]: nb/intel/haswell: Get rid of device_t

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/26196 )

Change subject: nb/intel/haswell: Get rid of device_t
......................................................................


Patch Set 1:

(5 comments)

https://review.coreboot.org/#/c/26196/1/src/northbridge/intel/haswell/gma.c
File src/northbridge/intel/haswell/gma.c:

https://review.coreboot.org/#/c/26196/1/src/northbridge/intel/haswell/gma.c@490
PS1, Line 490: static void gma_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
overline


https://review.coreboot.org/#/c/26196/1/src/northbridge/intel/haswell/minihd.c
File src/northbridge/intel/haswell/minihd.c:

https://review.coreboot.org/#/c/26196/1/src/northbridge/intel/haswell/minihd.c@106
PS1, Line 106: static void minihd_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
overline


https://review.coreboot.org/#/c/26196/1/src/northbridge/intel/haswell/northbridge.c
File src/northbridge/intel/haswell/northbridge.c:

https://review.coreboot.org/#/c/26196/1/src/northbridge/intel/haswell/northbridge.c@36
PS1, Line 36: static int get_pcie_bar(struct device *dev, unsigned int index, u32 *base, u32 *len)
overline


https://review.coreboot.org/#/c/26196/1/src/northbridge/intel/haswell/northbridge.c@109
PS1, Line 109: static int get_bar_in_mchbar(struct device *dev, unsigned int index, u32 *base, u32 *len)
overline


https://review.coreboot.org/#/c/26196/1/src/northbridge/intel/haswell/northbridge.c@409
PS1, Line 409: static void intel_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
overline



-- 
To view, visit https://review.coreboot.org/26196
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10fb736a7406a6571dffce883fb82c2711526762
Gerrit-Change-Number: 26196
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Thu, 10 May 2018 10:12:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180510/b46efb4f/attachment.html>