[coreboot-gerrit] Change in coreboot[master]: nb/intel/fsp_sandybridge: Get rid of device_t

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/26195 )

Change subject: nb/intel/fsp_sandybridge: Get rid of device_t
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/26195/2/src/northbridge/intel/fsp_sandybridge/gma.c
File src/northbridge/intel/fsp_sandybridge/gma.c:

https://review.coreboot.org/#/c/26195/2/src/northbridge/intel/fsp_sandybridge/gma.c@69
PS2, Line 69: static void gma_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
overline


https://review.coreboot.org/#/c/26195/2/src/northbridge/intel/fsp_sandybridge/northbridge.c
File src/northbridge/intel/fsp_sandybridge/northbridge.c:

https://review.coreboot.org/#/c/26195/2/src/northbridge/intel/fsp_sandybridge/northbridge.c@252
PS2, Line 252: static void intel_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
overline


https://review.coreboot.org/#/c/26195/2/src/northbridge/intel/fsp_sandybridge/northbridge.c@289
PS2, Line 289: 	const struct device *dev = dev_find_slot(0, PCI_DEVFN(0, 0));
remove 'const'. No idea how it could be added if it doesn't compile...



-- 
To view, visit https://review.coreboot.org/26195
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3289c891e8a81c750fc3f5fad0fd16c0f2702fe
Gerrit-Change-Number: 26195
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Thu, 10 May 2018 10:11:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180510/53d29a93/attachment.html>