<p><a href="https://review.coreboot.org/26195">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26195/2/src/northbridge/intel/fsp_sandybridge/gma.c">File src/northbridge/intel/fsp_sandybridge/gma.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26195/2/src/northbridge/intel/fsp_sandybridge/gma.c@69">Patch Set #2, Line 69:</a> <code style="font-family:monospace,monospace">static void gma_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">overline</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26195/2/src/northbridge/intel/fsp_sandybridge/northbridge.c">File src/northbridge/intel/fsp_sandybridge/northbridge.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26195/2/src/northbridge/intel/fsp_sandybridge/northbridge.c@252">Patch Set #2, Line 252:</a> <code style="font-family:monospace,monospace">static void intel_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">overline</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26195/2/src/northbridge/intel/fsp_sandybridge/northbridge.c@289">Patch Set #2, Line 289:</a> <code style="font-family:monospace,monospace">     const struct device *dev = dev_find_slot(0, PCI_DEVFN(0, 0));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">remove 'const'. No idea how it could be added if it doesn't compile...</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26195">change 26195</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26195"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id3289c891e8a81c750fc3f5fad0fd16c0f2702fe </div>
<div style="display:none"> Gerrit-Change-Number: 26195 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 10 May 2018 10:11:40 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>