[coreboot-gerrit] Change in coreboot[master]: agesa/family16kb/northbridge: report acpi namespace

Kevin Cody-Little (Code Review) gerrit at coreboot.org
Wed May 9 20:46:56 CEST 2018


Kevin Cody-Little has uploaded this change for review. ( https://review.coreboot.org/26204


Change subject: agesa/family16kb/northbridge: report acpi namespace
......................................................................

agesa/family16kb/northbridge: report acpi namespace

Add a function domain_acpi_name to return "PCI0", rather than
falling back to the parent' device's "\_SB" label. This repair is
required for the LPC TPM device to register its presence without
blowing up the table and preventing the payload from finding SATA.

Before change, the TPM device reported as:

\_SB.\_SB.LPC0.TPM

After change, the TPM device reports as:

\_SB.PCI0.LPC0.TPM

A separate change submission will correct "LPC0" as well.

Change-Id: I5e8d4715c9b42f50c84dd65818e4b0fdfc9d54f9
Signed-off-by: Kevin Cody-Little <kcodyjr at gmail.com>
---
M src/northbridge/amd/agesa/family16kb/northbridge.c
1 file changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/26204/1

diff --git a/src/northbridge/amd/agesa/family16kb/northbridge.c b/src/northbridge/amd/agesa/family16kb/northbridge.c
index f667f6f..8e5e472 100644
--- a/src/northbridge/amd/agesa/family16kb/northbridge.c
+++ b/src/northbridge/amd/agesa/family16kb/northbridge.c
@@ -795,11 +795,20 @@
 	}
 }
 
+static const char *domain_acpi_name(const struct device *dev)
+{
+	if (dev->path.type == DEVICE_PATH_DOMAIN)
+		return "PCI0";
+
+	return NULL;
+}
+
 static struct device_operations pci_domain_ops = {
 	.read_resources	  = domain_read_resources,
 	.set_resources	  = domain_set_resources,
 	.init		  = DEVICE_NOOP,
 	.scan_bus	  = pci_domain_scan_bus,
+	.acpi_name        = domain_acpi_name,
 };
 
 static void sysconf_init(device_t dev) // first node

-- 
To view, visit https://review.coreboot.org/26204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e8d4715c9b42f50c84dd65818e4b0fdfc9d54f9
Gerrit-Change-Number: 26204
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Cody-Little <kcodyjr at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180509/52237054/attachment.html>


More information about the coreboot-gerrit mailing list