<p>Kevin Cody-Little has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26204">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">agesa/family16kb/northbridge: report acpi namespace<br><br>Add a function domain_acpi_name to return "PCI0", rather than<br>falling back to the parent' device's "\_SB" label. This repair is<br>required for the LPC TPM device to register its presence without<br>blowing up the table and preventing the payload from finding SATA.<br><br>Before change, the TPM device reported as:<br><br>\_SB.\_SB.LPC0.TPM<br><br>After change, the TPM device reports as:<br><br>\_SB.PCI0.LPC0.TPM<br><br>A separate change submission will correct "LPC0" as well.<br><br>Change-Id: I5e8d4715c9b42f50c84dd65818e4b0fdfc9d54f9<br>Signed-off-by: Kevin Cody-Little <kcodyjr@gmail.com><br>---<br>M src/northbridge/amd/agesa/family16kb/northbridge.c<br>1 file changed, 9 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/26204/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/amd/agesa/family16kb/northbridge.c b/src/northbridge/amd/agesa/family16kb/northbridge.c</span><br><span>index f667f6f..8e5e472 100644</span><br><span>--- a/src/northbridge/amd/agesa/family16kb/northbridge.c</span><br><span>+++ b/src/northbridge/amd/agesa/family16kb/northbridge.c</span><br><span>@@ -795,11 +795,20 @@</span><br><span>        }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static const char *domain_acpi_name(const struct device *dev)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+  if (dev->path.type == DEVICE_PATH_DOMAIN)</span><br><span style="color: hsl(120, 100%, 40%);">+          return "PCI0";</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+    return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static struct device_operations pci_domain_ops = {</span><br><span>      .read_resources   = domain_read_resources,</span><br><span>   .set_resources    = domain_set_resources,</span><br><span>    .init             = DEVICE_NOOP,</span><br><span>     .scan_bus         = pci_domain_scan_bus,</span><br><span style="color: hsl(120, 100%, 40%);">+      .acpi_name        = domain_acpi_name,</span><br><span> };</span><br><span> </span><br><span> static void sysconf_init(device_t dev) // first node</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26204">change 26204</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26204"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5e8d4715c9b42f50c84dd65818e4b0fdfc9d54f9 </div>
<div style="display:none"> Gerrit-Change-Number: 26204 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Cody-Little <kcodyjr@gmail.com> </div>