[coreboot-gerrit] Change in coreboot[master]: agesa/hudson/southbridge: add acpi name reporting for lpc

[Kevin Cody-Little (Code Review)]

Kevin Cody-Little has uploaded this change for review. ( https://review.coreboot.org/26205


Change subject: agesa/hudson/southbridge: add acpi name reporting for lpc
......................................................................

agesa/hudson/southbridge: add acpi name reporting for lpc

Add an lpc_acpi_name function to report its namespace as "LIBR"
rather than some fallback value which seems to vary. This repair
is required for the LPC TPM device to register its presence
without blowing up the table and preventing the payload from
seeing the SATA device.

Before change (but after other similar change to PCI0), the
TPM device reported itself as:

\_SB.PCI0.LPC0.TPM

After change, the TPM device reports as:

\_SB.PCI0.LIBR.TPM

which is consistent with the tables AGESA generates.

Change-Id: Ifa3a0e386cc00062855331e5f9d1c00d6541c238
Signed-off-by: Kevin Cody-Little <kcodyjr at gmail.com>
---
M src/southbridge/amd/agesa/hudson/lpc.c
1 file changed, 13 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/26205/1

diff --git a/src/southbridge/amd/agesa/hudson/lpc.c b/src/southbridge/amd/agesa/hudson/lpc.c
index 1166054..7ada832 100644
--- a/src/southbridge/amd/agesa/hudson/lpc.c
+++ b/src/southbridge/amd/agesa/hudson/lpc.c
@@ -29,6 +29,7 @@
 #include <pc80/i8254.h>
 #include <pc80/i8259.h>
 #include "hudson.h"
+#include "pci_devs.h"
 
 static void lpc_init(device_t dev)
 {
@@ -318,6 +319,17 @@
 	hudson_lpc_enable_childrens_resources(dev);
 }
 
+static const char *lpc_acpi_name(const struct device *dev)
+{
+	if (dev->path.type != DEVICE_PATH_PCI)
+		return NULL;
+
+	if (dev->path.pci.devfn == LPC_DEVFN)
+		return "LIBR";
+
+	return NULL;
+}
+
 unsigned long acpi_fill_mcfg(unsigned long current)
 {
 	/* Just a dummy */
@@ -338,6 +350,7 @@
 	.init = lpc_init,
 	.scan_bus = scan_lpc_bus,
 	.ops_pci = &lops_pci,
+	.acpi_name = lpc_acpi_name,
 };
 static const struct pci_driver lpc_driver __pci_driver = {
 	.ops = &lpc_ops,

-- 
To view, visit https://review.coreboot.org/26205
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa3a0e386cc00062855331e5f9d1c00d6541c238
Gerrit-Change-Number: 26205
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Cody-Little <kcodyjr at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180509/85258ea0/attachment-0001.html>