<p>Kevin Cody-Little has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26205">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">agesa/hudson/southbridge: add acpi name reporting for lpc<br><br>Add an lpc_acpi_name function to report its namespace as "LIBR"<br>rather than some fallback value which seems to vary. This repair<br>is required for the LPC TPM device to register its presence<br>without blowing up the table and preventing the payload from<br>seeing the SATA device.<br><br>Before change (but after other similar change to PCI0), the<br>TPM device reported itself as:<br><br>\_SB.PCI0.LPC0.TPM<br><br>After change, the TPM device reports as:<br><br>\_SB.PCI0.LIBR.TPM<br><br>which is consistent with the tables AGESA generates.<br><br>Change-Id: Ifa3a0e386cc00062855331e5f9d1c00d6541c238<br>Signed-off-by: Kevin Cody-Little <kcodyjr@gmail.com><br>---<br>M src/southbridge/amd/agesa/hudson/lpc.c<br>1 file changed, 13 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/26205/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/southbridge/amd/agesa/hudson/lpc.c b/src/southbridge/amd/agesa/hudson/lpc.c</span><br><span>index 1166054..7ada832 100644</span><br><span>--- a/src/southbridge/amd/agesa/hudson/lpc.c</span><br><span>+++ b/src/southbridge/amd/agesa/hudson/lpc.c</span><br><span>@@ -29,6 +29,7 @@</span><br><span> #include <pc80/i8254.h></span><br><span> #include <pc80/i8259.h></span><br><span> #include "hudson.h"</span><br><span style="color: hsl(120, 100%, 40%);">+#include "pci_devs.h"</span><br><span> </span><br><span> static void lpc_init(device_t dev)</span><br><span> {</span><br><span>@@ -318,6 +319,17 @@</span><br><span>        hudson_lpc_enable_childrens_resources(dev);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static const char *lpc_acpi_name(const struct device *dev)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+   if (dev->path.type != DEVICE_PATH_PCI)</span><br><span style="color: hsl(120, 100%, 40%);">+             return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        if (dev->path.pci.devfn == LPC_DEVFN)</span><br><span style="color: hsl(120, 100%, 40%);">+              return "LIBR";</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+    return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> unsigned long acpi_fill_mcfg(unsigned long current)</span><br><span> {</span><br><span>        /* Just a dummy */</span><br><span>@@ -338,6 +350,7 @@</span><br><span>     .init = lpc_init,</span><br><span>    .scan_bus = scan_lpc_bus,</span><br><span>    .ops_pci = &lops_pci,</span><br><span style="color: hsl(120, 100%, 40%);">+     .acpi_name = lpc_acpi_name,</span><br><span> };</span><br><span> static const struct pci_driver lpc_driver __pci_driver = {</span><br><span>      .ops = &lpc_ops,</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26205">change 26205</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26205"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ifa3a0e386cc00062855331e5f9d1c00d6541c238 </div>
<div style="display:none"> Gerrit-Change-Number: 26205 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Cody-Little <kcodyjr@gmail.com> </div>