[coreboot-gerrit] Change in coreboot[master]: Intel haswell/broadwell: CPL2 method doesn't use any arguments

[Martin Roth (Code Review)]

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/26149


Change subject: Intel haswell/broadwell: CPL2 method doesn't use any arguments
......................................................................

Intel haswell/broadwell: CPL2 method doesn't use any arguments

- Update the CPL2 method to not take any arguments.
- Don't pass the Method any values.

Change-Id: I7fb96fc7f22a387d796752dcfce4639293c45e5e
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/northbridge/intel/haswell/acpi/hostbridge.asl
M src/soc/intel/broadwell/acpi/ctdp.asl
2 files changed, 6 insertions(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/26149/1

diff --git a/src/northbridge/intel/haswell/acpi/hostbridge.asl b/src/northbridge/intel/haswell/acpi/hostbridge.asl
index 2565851..ed2284a 100644
--- a/src/northbridge/intel/haswell/acpi/hostbridge.asl
+++ b/src/northbridge/intel/haswell/acpi/hostbridge.asl
@@ -172,7 +172,7 @@
 	}
 
 	/* Calculate PL2 based on chip type */
-	Method (CPL2, 1, NotSerialized)
+	Method (CPL2, 0, NotSerialized)
 	{
 		If (\ISLP ()) {
 			/* Haswell ULT PL2 = 25W */
@@ -207,7 +207,7 @@
 		PPCN ()
 
 		/* Set PL2 */
-		Store (CPL2 (CTDD), PL2V)
+		Store (CPL2 (), PL2V)
 
 		/* Set PL1 */
 		Store (CTDD, PL1V)
@@ -236,7 +236,7 @@
 		Store (CTDN, PL1V)
 
 		/* Set PL2 */
-		Store (CPL2 (CTDN), PL2V)
+		Store (CPL2 (), PL2V)
 
 		/* Set PPC limit and notify OS */
 		Store (PSSS (TARN), PPCM)
diff --git a/src/soc/intel/broadwell/acpi/ctdp.asl b/src/soc/intel/broadwell/acpi/ctdp.asl
index e6aad21..0fc6c66 100644
--- a/src/soc/intel/broadwell/acpi/ctdp.asl
+++ b/src/soc/intel/broadwell/acpi/ctdp.asl
@@ -92,7 +92,7 @@
 	}
 
 	/* Calculate PL2 based on chip type */
-	Method (CPL2, 1, NotSerialized)
+	Method (CPL2, 0, NotSerialized)
 	{
 		/* Haswell ULT PL2 = 25W */
 		/* FIXME: update for broadwell */
@@ -123,7 +123,7 @@
 		PPCN ()
 
 		/* Set PL2 */
-		Store (CPL2 (CTDD), PL2V)
+		Store (CPL2 (), PL2V)
 
 		/* Set PL1 */
 		Store (CTDD, PL1V)
@@ -152,7 +152,7 @@
 		Store (CTDN, PL1V)
 
 		/* Set PL2 */
-		Store (CPL2 (CTDN), PL2V)
+		Store (CPL2 (), PL2V)
 
 		/* Set PPC limit and notify OS */
 		Store (PSSS (TARN), PPCM)

-- 
To view, visit https://review.coreboot.org/26149
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fb96fc7f22a387d796752dcfce4639293c45e5e
Gerrit-Change-Number: 26149
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180508/3e8d0aff/attachment.html>