[coreboot-gerrit] Change in coreboot[master]: mainboard/hp/dl145_g1: WAK ACPI method doesn't use an argument

Martin Roth (Code Review) gerrit at coreboot.org
Mon May 7 05:51:52 CEST 2018


Martin Roth has uploaded this change for review. ( https://review.coreboot.org/26128


Change subject: mainboard/hp/dl145_g1: WAK ACPI method doesn't use an argument
......................................................................

mainboard/hp/dl145_g1: WAK ACPI method doesn't use an argument

Since the WAK method doesn't use any arguments, don't say that it has
one, and don't pass it one.

Change-Id: I16cdf2781ce1bf9458300de70a87a3bb98d01636
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/hp/dl145_g1/dsdt.asl
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/26128/1

diff --git a/src/mainboard/hp/dl145_g1/dsdt.asl b/src/mainboard/hp/dl145_g1/dsdt.asl
index 5227c3a..7c5babd 100644
--- a/src/mainboard/hp/dl145_g1/dsdt.asl
+++ b/src/mainboard/hp/dl145_g1/dsdt.asl
@@ -205,7 +205,7 @@
 
 	#include <southbridge/amd/amd8111/acpi/sleepstates.asl>
 
-	Method (WAK, 1, NotSerialized) {}
+	Method (WAK, 0, NotSerialized) {}
 
 	Name (WAKP, Package (0x02) { 0x00, 0x00 })
 	// Status
@@ -220,7 +220,7 @@
 	// Arg0: The value of the sleeping state from which woken (1=S1, ...)
 	// Result: (2 DWORD package)
 		ShiftLeft (Arg0, 0x04, DBG8)
-		WAK (Arg0)
+		WAK ()
 		Store (0xFF, KSBI) // Clear 0xFF in CMOS RAM
 		Store (0x00, KSBD)
 		If (LEqual (Arg0, 0x01)) { // Wake from S1 state

-- 
To view, visit https://review.coreboot.org/26128
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16cdf2781ce1bf9458300de70a87a3bb98d01636
Gerrit-Change-Number: 26128
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180507/8d01f3e3/attachment.html>


More information about the coreboot-gerrit mailing list