<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26128">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/hp/dl145_g1: WAK ACPI method doesn't use an argument<br><br>Since the WAK method doesn't use any arguments, don't say that it has<br>one, and don't pass it one.<br><br>Change-Id: I16cdf2781ce1bf9458300de70a87a3bb98d01636<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/mainboard/hp/dl145_g1/dsdt.asl<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/26128/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/hp/dl145_g1/dsdt.asl b/src/mainboard/hp/dl145_g1/dsdt.asl</span><br><span>index 5227c3a..7c5babd 100644</span><br><span>--- a/src/mainboard/hp/dl145_g1/dsdt.asl</span><br><span>+++ b/src/mainboard/hp/dl145_g1/dsdt.asl</span><br><span>@@ -205,7 +205,7 @@</span><br><span> </span><br><span>        #include <southbridge/amd/amd8111/acpi/sleepstates.asl></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       Method (WAK, 1, NotSerialized) {}</span><br><span style="color: hsl(120, 100%, 40%);">+     Method (WAK, 0, NotSerialized) {}</span><br><span> </span><br><span>        Name (WAKP, Package (0x02) { 0x00, 0x00 })</span><br><span>   // Status</span><br><span>@@ -220,7 +220,7 @@</span><br><span>      // Arg0: The value of the sleeping state from which woken (1=S1, ...)</span><br><span>        // Result: (2 DWORD package)</span><br><span>                 ShiftLeft (Arg0, 0x04, DBG8)</span><br><span style="color: hsl(0, 100%, 40%);">-            WAK (Arg0)</span><br><span style="color: hsl(120, 100%, 40%);">+            WAK ()</span><br><span>               Store (0xFF, KSBI) // Clear 0xFF in CMOS RAM</span><br><span>                 Store (0x00, KSBD)</span><br><span>           If (LEqual (Arg0, 0x01)) { // Wake from S1 state</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26128">change 26128</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26128"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I16cdf2781ce1bf9458300de70a87a3bb98d01636 </div>
<div style="display:none"> Gerrit-Change-Number: 26128 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>