[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Update DTRP ACPI method so both arguments are used

[Martin Roth (Code Review)]

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/26127


Change subject: soc/intel/skylake: Update DTRP ACPI method so both arguments are used
......................................................................

soc/intel/skylake: Update DTRP ACPI method so both arguments are used

Previously, because the two arguments were wrapped with preprocessor
conditionals, the compiler couldn't see that both were being used.  This
uses a local variable for the conditional instead and avoids the
warning.

Change-Id: Id9017894f475250cde6900f46d497cc71ee1bba0
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/soc/intel/skylake/acpi/dptf/thermal.asl
1 file changed, 7 insertions(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/26127/1

diff --git a/src/soc/intel/skylake/acpi/dptf/thermal.asl b/src/soc/intel/skylake/acpi/dptf/thermal.asl
index 8290392..5dd5e02 100644
--- a/src/soc/intel/skylake/acpi/dptf/thermal.asl
+++ b/src/soc/intel/skylake/acpi/dptf/thermal.asl
@@ -83,14 +83,16 @@
 Method (DTRP, 2, Serialized)
 {
 #ifdef EC_ENABLE_TABLET_EVENT
+	Store(One. Local0)
+#else
+	Store(Zero. Local0)
+#endif
+	If (Lequal (Local0, Zero) {
+		Return (CTOK (Arg1))
+	}
 	If (LEqual (\_SB.PCI0.LPCB.EC0.RCTM, One)) {
 		Return (CTOK (Arg0))
-	} Else {
-#endif
-		Return (CTOK (Arg1))
-#ifdef EC_ENABLE_TABLET_EVENT
 	}
-#endif
 }
 
 #ifdef DPTF_TSR0_SENSOR_ID

-- 
To view, visit https://review.coreboot.org/26127
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9017894f475250cde6900f46d497cc71ee1bba0
Gerrit-Change-Number: 26127
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180507/873eabe5/attachment.html>