<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26127">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: Update DTRP ACPI method so both arguments are used<br><br>Previously, because the two arguments were wrapped with preprocessor<br>conditionals, the compiler couldn't see that both were being used.  This<br>uses a local variable for the conditional instead and avoids the<br>warning.<br><br>Change-Id: Id9017894f475250cde6900f46d497cc71ee1bba0<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/soc/intel/skylake/acpi/dptf/thermal.asl<br>1 file changed, 7 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/26127/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/skylake/acpi/dptf/thermal.asl b/src/soc/intel/skylake/acpi/dptf/thermal.asl</span><br><span>index 8290392..5dd5e02 100644</span><br><span>--- a/src/soc/intel/skylake/acpi/dptf/thermal.asl</span><br><span>+++ b/src/soc/intel/skylake/acpi/dptf/thermal.asl</span><br><span>@@ -83,14 +83,16 @@</span><br><span> Method (DTRP, 2, Serialized)</span><br><span> {</span><br><span> #ifdef EC_ENABLE_TABLET_EVENT</span><br><span style="color: hsl(120, 100%, 40%);">+       Store(One. Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+     Store(Zero. Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+   If (Lequal (Local0, Zero) {</span><br><span style="color: hsl(120, 100%, 40%);">+           Return (CTOK (Arg1))</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span>    If (LEqual (\_SB.PCI0.LPCB.EC0.RCTM, One)) {</span><br><span>                 Return (CTOK (Arg0))</span><br><span style="color: hsl(0, 100%, 40%);">-    } Else {</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(0, 100%, 40%);">-          Return (CTOK (Arg1))</span><br><span style="color: hsl(0, 100%, 40%);">-#ifdef EC_ENABLE_TABLET_EVENT</span><br><span>    }</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span> }</span><br><span> </span><br><span> #ifdef DPTF_TSR0_SENSOR_ID</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26127">change 26127</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26127"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id9017894f475250cde6900f46d497cc71ee1bba0 </div>
<div style="display:none"> Gerrit-Change-Number: 26127 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>