[coreboot-gerrit] Change in coreboot[master]: ACPI: Set the correct number of arguments in ACPI methods.

[Martin Roth (Code Review)]

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/26125


Change subject: ACPI: Set the correct number of arguments in ACPI methods.
......................................................................

ACPI: Set the correct number of arguments in ACPI methods.

These methods all had unused arguments and could be corrected by
setting the correct number in the method initializer.

Change-Id: I86606cfa1c391e2221cee31994e83667fa9ead61
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/drivers/intel/gma/acpi/common.asl
M src/mainboard/getac/p470/acpi/ec.asl
M src/northbridge/intel/haswell/acpi/hostbridge.asl
M src/soc/intel/broadwell/acpi/ctdp.asl
4 files changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/26125/1

diff --git a/src/drivers/intel/gma/acpi/common.asl b/src/drivers/intel/gma/acpi/common.asl
index dd294fe..7415859 100644
--- a/src/drivers/intel/gma/acpi/common.asl
+++ b/src/drivers/intel/gma/acpi/common.asl
@@ -97,7 +97,7 @@
 	}
 
 	/* Device Set State */
-	Method(XDSS, 2)
+	Method(XDSS, 1)
 	{
 		/* If Parameter Arg0 is (1 << 31) | (1 << 30), the
 		 * display switch was completed
diff --git a/src/mainboard/getac/p470/acpi/ec.asl b/src/mainboard/getac/p470/acpi/ec.asl
index 91846f1..f23341f 100644
--- a/src/mainboard/getac/p470/acpi/ec.asl
+++ b/src/mainboard/getac/p470/acpi/ec.asl
@@ -547,7 +547,7 @@
 		}
 
 		/* Set DKD */
-		Method(SDKD, 1, Serialized)
+		Method(SDKD, 0, Serialized)
 		{
 			TRAP(0xda)
 			Return (0)
diff --git a/src/northbridge/intel/haswell/acpi/hostbridge.asl b/src/northbridge/intel/haswell/acpi/hostbridge.asl
index 2565851..db1bf4f 100644
--- a/src/northbridge/intel/haswell/acpi/hostbridge.asl
+++ b/src/northbridge/intel/haswell/acpi/hostbridge.asl
@@ -172,7 +172,7 @@
 	}
 
 	/* Calculate PL2 based on chip type */
-	Method (CPL2, 1, NotSerialized)
+	Method (CPL2, 0, NotSerialized)
 	{
 		If (\ISLP ()) {
 			/* Haswell ULT PL2 = 25W */
diff --git a/src/soc/intel/broadwell/acpi/ctdp.asl b/src/soc/intel/broadwell/acpi/ctdp.asl
index e6aad21..6142862 100644
--- a/src/soc/intel/broadwell/acpi/ctdp.asl
+++ b/src/soc/intel/broadwell/acpi/ctdp.asl
@@ -92,7 +92,7 @@
 	}
 
 	/* Calculate PL2 based on chip type */
-	Method (CPL2, 1, NotSerialized)
+	Method (CPL2, 0, NotSerialized)
 	{
 		/* Haswell ULT PL2 = 25W */
 		/* FIXME: update for broadwell */

-- 
To view, visit https://review.coreboot.org/26125
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I86606cfa1c391e2221cee31994e83667fa9ead61
Gerrit-Change-Number: 26125
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180507/b81ebca0/attachment-0001.html>