<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26125">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ACPI: Set the correct number of arguments in ACPI methods.<br><br>These methods all had unused arguments and could be corrected by<br>setting the correct number in the method initializer.<br><br>Change-Id: I86606cfa1c391e2221cee31994e83667fa9ead61<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/drivers/intel/gma/acpi/common.asl<br>M src/mainboard/getac/p470/acpi/ec.asl<br>M src/northbridge/intel/haswell/acpi/hostbridge.asl<br>M src/soc/intel/broadwell/acpi/ctdp.asl<br>4 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/26125/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/intel/gma/acpi/common.asl b/src/drivers/intel/gma/acpi/common.asl</span><br><span>index dd294fe..7415859 100644</span><br><span>--- a/src/drivers/intel/gma/acpi/common.asl</span><br><span>+++ b/src/drivers/intel/gma/acpi/common.asl</span><br><span>@@ -97,7 +97,7 @@</span><br><span>       }</span><br><span> </span><br><span>        /* Device Set State */</span><br><span style="color: hsl(0, 100%, 40%);">-  Method(XDSS, 2)</span><br><span style="color: hsl(120, 100%, 40%);">+       Method(XDSS, 1)</span><br><span>      {</span><br><span>            /* If Parameter Arg0 is (1 << 31) | (1 << 30), the</span><br><span>                * display switch was completed</span><br><span>diff --git a/src/mainboard/getac/p470/acpi/ec.asl b/src/mainboard/getac/p470/acpi/ec.asl</span><br><span>index 91846f1..f23341f 100644</span><br><span>--- a/src/mainboard/getac/p470/acpi/ec.asl</span><br><span>+++ b/src/mainboard/getac/p470/acpi/ec.asl</span><br><span>@@ -547,7 +547,7 @@</span><br><span>           }</span><br><span> </span><br><span>                /* Set DKD */</span><br><span style="color: hsl(0, 100%, 40%);">-           Method(SDKD, 1, Serialized)</span><br><span style="color: hsl(120, 100%, 40%);">+           Method(SDKD, 0, Serialized)</span><br><span>          {</span><br><span>                    TRAP(0xda)</span><br><span>                   Return (0)</span><br><span>diff --git a/src/northbridge/intel/haswell/acpi/hostbridge.asl b/src/northbridge/intel/haswell/acpi/hostbridge.asl</span><br><span>index 2565851..db1bf4f 100644</span><br><span>--- a/src/northbridge/intel/haswell/acpi/hostbridge.asl</span><br><span>+++ b/src/northbridge/intel/haswell/acpi/hostbridge.asl</span><br><span>@@ -172,7 +172,7 @@</span><br><span>    }</span><br><span> </span><br><span>        /* Calculate PL2 based on chip type */</span><br><span style="color: hsl(0, 100%, 40%);">-  Method (CPL2, 1, NotSerialized)</span><br><span style="color: hsl(120, 100%, 40%);">+       Method (CPL2, 0, NotSerialized)</span><br><span>      {</span><br><span>            If (\ISLP ()) {</span><br><span>                      /* Haswell ULT PL2 = 25W */</span><br><span>diff --git a/src/soc/intel/broadwell/acpi/ctdp.asl b/src/soc/intel/broadwell/acpi/ctdp.asl</span><br><span>index e6aad21..6142862 100644</span><br><span>--- a/src/soc/intel/broadwell/acpi/ctdp.asl</span><br><span>+++ b/src/soc/intel/broadwell/acpi/ctdp.asl</span><br><span>@@ -92,7 +92,7 @@</span><br><span>     }</span><br><span> </span><br><span>        /* Calculate PL2 based on chip type */</span><br><span style="color: hsl(0, 100%, 40%);">-  Method (CPL2, 1, NotSerialized)</span><br><span style="color: hsl(120, 100%, 40%);">+       Method (CPL2, 0, NotSerialized)</span><br><span>      {</span><br><span>            /* Haswell ULT PL2 = 25W */</span><br><span>          /* FIXME: update for broadwell */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26125">change 26125</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26125"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I86606cfa1c391e2221cee31994e83667fa9ead61 </div>
<div style="display:none"> Gerrit-Change-Number: 26125 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>