[coreboot-gerrit] Change in coreboot[master]: mainboard/google/.../terra: Fix ACPI external definition errors
Martin Roth (Code Review)
gerrit at coreboot.org
Mon May 7 01:16:33 CEST 2018
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/26122
Change subject: mainboard/google/.../terra: Fix ACPI external definition errors
......................................................................
mainboard/google/.../terra: Fix ACPI external definition errors
According to ACPI 6.1 spec 19.6.44, External informs compiler that
object is external to this TABLE, no necessary for object in same DSDT
tables.
A name cannot be defined and declared external in the same table (GPID)
A name cannot be defined and declared external in the same table (CTOK)
Change-Id: Ica80b59ad6a8af865bf1551ac4e014ec5f4e7d08
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/cyan/variants/terra/include/variant/acpi/cpu.asl
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/26122/1
diff --git a/src/mainboard/google/cyan/variants/terra/include/variant/acpi/cpu.asl b/src/mainboard/google/cyan/variants/terra/include/variant/acpi/cpu.asl
index bab215d..5f212bd 100644
--- a/src/mainboard/google/cyan/variants/terra/include/variant/acpi/cpu.asl
+++ b/src/mainboard/google/cyan/variants/terra/include/variant/acpi/cpu.asl
@@ -47,8 +47,6 @@
External (\_PR.CP00._PTC, PkgObj)
External (\_PR.CP00._TSD, PkgObj)
External (\_PR.CP00._PSS, MethodObj)
-External (\_SB.DPTF.CTOK, MethodObj)
-External (\_SB.GPID, MethodObj)
Device (B0DB)
{
--
To view, visit https://review.coreboot.org/26122
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica80b59ad6a8af865bf1551ac4e014ec5f4e7d08
Gerrit-Change-Number: 26122
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180506/50c96ae4/attachment.html>
More information about the coreboot-gerrit
mailing list