<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26122">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/.../terra: Fix ACPI external definition errors<br><br>According to ACPI 6.1 spec 19.6.44, External informs compiler that<br>object is external to this TABLE, no necessary for object in same DSDT<br>tables.<br><br>A name cannot be defined and declared external in the same table (GPID)<br>A name cannot be defined and declared external in the same table (CTOK)<br><br>Change-Id: Ica80b59ad6a8af865bf1551ac4e014ec5f4e7d08<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/mainboard/google/cyan/variants/terra/include/variant/acpi/cpu.asl<br>1 file changed, 0 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/26122/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/cyan/variants/terra/include/variant/acpi/cpu.asl b/src/mainboard/google/cyan/variants/terra/include/variant/acpi/cpu.asl</span><br><span>index bab215d..5f212bd 100644</span><br><span>--- a/src/mainboard/google/cyan/variants/terra/include/variant/acpi/cpu.asl</span><br><span>+++ b/src/mainboard/google/cyan/variants/terra/include/variant/acpi/cpu.asl</span><br><span>@@ -47,8 +47,6 @@</span><br><span> External (\_PR.CP00._PTC, PkgObj)</span><br><span> External (\_PR.CP00._TSD, PkgObj)</span><br><span> External (\_PR.CP00._PSS, MethodObj)</span><br><span style="color: hsl(0, 100%, 40%);">-External (\_SB.DPTF.CTOK, MethodObj)</span><br><span style="color: hsl(0, 100%, 40%);">-External (\_SB.GPID, MethodObj)</span><br><span> </span><br><span> Device (B0DB)</span><br><span> {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26122">change 26122</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26122"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ica80b59ad6a8af865bf1551ac4e014ec5f4e7d08 </div>
<div style="display:none"> Gerrit-Change-Number: 26122 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>