[coreboot-gerrit] Change in coreboot[master]: src/device: Get rid of device_t

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/26067 )

Change subject: src/device: Get rid of device_t
......................................................................


Patch Set 4:

(3 comments)

https://review.coreboot.org/#/c/26067/4/src/device/cpu_device.c
File src/device/cpu_device.c:

https://review.coreboot.org/#/c/26067/4/src/device/cpu_device.c@20
PS4, Line 20: struct device *add_cpu_device(struct bus *cpu_bus, unsigned apic_id, int enabled)
overline

Do you need to change the function prototypes in the headers ? If not please mention it in the commit message.


https://review.coreboot.org/#/c/26067/4/src/device/cpu_device.c@44
PS4, Line 44: void set_cpu_topology(struct device *cpu, unsigned node, unsigned package, unsigned core, unsigned thread)
overline


https://review.coreboot.org/#/c/26067/4/src/device/pci_rom.c
File src/device/pci_rom.c:

https://review.coreboot.org/#/c/26067/4/src/device/pci_rom.c@156
PS4, Line 156: 		extern struct device *vga_pri; /* Primary VGA device (device.c). */
you should also change device_t vga_pri in device.c in this commit



-- 
To view, visit https://review.coreboot.org/26067
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bd8b93922f113bdaf7ba460acf6a7d62c4df013
Gerrit-Change-Number: 26067
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Sun, 06 May 2018 16:54:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180506/53c94ecd/attachment.html>