<p><a href="https://review.coreboot.org/26067">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26067/4/src/device/cpu_device.c">File src/device/cpu_device.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26067/4/src/device/cpu_device.c@20">Patch Set #4, Line 20:</a> <code style="font-family:monospace,monospace">struct device *add_cpu_device(struct bus *cpu_bus, unsigned apic_id, int enabled)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">overline</p><p style="white-space: pre-wrap; word-wrap: break-word;">Do you need to change the function prototypes in the headers ? If not please mention it in the commit message.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26067/4/src/device/cpu_device.c@44">Patch Set #4, Line 44:</a> <code style="font-family:monospace,monospace">void set_cpu_topology(struct device *cpu, unsigned node, unsigned package, unsigned core, unsigned thread)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">overline</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26067/4/src/device/pci_rom.c">File src/device/pci_rom.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26067/4/src/device/pci_rom.c@156">Patch Set #4, Line 156:</a> <code style="font-family:monospace,monospace">                extern struct device *vga_pri; /* Primary VGA device (device.c). */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">you should also change device_t vga_pri in device.c in this commit</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26067">change 26067</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26067"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I7bd8b93922f113bdaf7ba460acf6a7d62c4df013 </div>
<div style="display:none"> Gerrit-Change-Number: 26067 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 06 May 2018 16:54:56 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>