[coreboot-gerrit] Change in coreboot[master]: mb/msi: Get rid of device_t

Elyes HAOUAS (Code Review) gerrit at coreboot.org
Fri May 4 22:07:44 CEST 2018


Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26102


Change subject: mb/msi: Get rid of device_t
......................................................................

mb/msi: Get rid of device_t

Use of device_t has been abandoned in ramstage.

Change-Id: I7f29fe3b85bc56ff3f2d225822c415513e961459
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/mainboard/msi/ms7135/acpi_tables.c
M src/mainboard/msi/ms7135/get_bus_conf.c
M src/mainboard/msi/ms7135/mptable.c
M src/mainboard/msi/ms7260/get_bus_conf.c
M src/mainboard/msi/ms7260/mptable.c
M src/mainboard/msi/ms7721/mainboard.c
M src/mainboard/msi/ms7721/mptable.c
M src/mainboard/msi/ms9185/get_bus_conf.c
M src/mainboard/msi/ms9185/mptable.c
M src/mainboard/msi/ms9282/get_bus_conf.c
M src/mainboard/msi/ms9282/mptable.c
M src/mainboard/msi/ms9652_fam10/acpi_tables.c
M src/mainboard/msi/ms9652_fam10/get_bus_conf.c
M src/mainboard/msi/ms9652_fam10/mptable.c
14 files changed, 15 insertions(+), 15 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/26102/1

diff --git a/src/mainboard/msi/ms7135/acpi_tables.c b/src/mainboard/msi/ms7135/acpi_tables.c
index c7482e0..a637637 100644
--- a/src/mainboard/msi/ms7135/acpi_tables.c
+++ b/src/mainboard/msi/ms7135/acpi_tables.c
@@ -16,7 +16,7 @@
 /* APIC */
 unsigned long acpi_fill_madt(unsigned long current)
 {
-	device_t dev;
+	struct device *dev;
 	struct resource *res;
 
 	/* create all subtables for processors */
diff --git a/src/mainboard/msi/ms7135/get_bus_conf.c b/src/mainboard/msi/ms7135/get_bus_conf.c
index 77b0b07..19b520f 100644
--- a/src/mainboard/msi/ms7135/get_bus_conf.c
+++ b/src/mainboard/msi/ms7135/get_bus_conf.c
@@ -49,7 +49,7 @@
 {
 	unsigned apicid_base;
 
-	device_t dev;
+	struct device *dev;
 	unsigned sbdn;
 	int i;
 
diff --git a/src/mainboard/msi/ms7135/mptable.c b/src/mainboard/msi/ms7135/mptable.c
index f4c26ca..35dc02c 100644
--- a/src/mainboard/msi/ms7135/mptable.c
+++ b/src/mainboard/msi/ms7135/mptable.c
@@ -46,7 +46,7 @@
 
 /* I/O APICs:	APIC ID	Version	State		Address*/
 	{
-		device_t dev;
+		struct device *dev;
 		struct resource *res;
 		u32 dword;
 
diff --git a/src/mainboard/msi/ms7260/get_bus_conf.c b/src/mainboard/msi/ms7260/get_bus_conf.c
index b1a03c1..d768041 100644
--- a/src/mainboard/msi/ms7260/get_bus_conf.c
+++ b/src/mainboard/msi/ms7260/get_bus_conf.c
@@ -63,7 +63,7 @@
 void get_bus_conf(void)
 {
 	unsigned int apicid_base, sbdn;
-	device_t dev;
+	struct device *dev;
 	int i;
 
 	if (get_bus_conf_done == 1)
diff --git a/src/mainboard/msi/ms7260/mptable.c b/src/mainboard/msi/ms7260/mptable.c
index 2ba4af9..6450d2d 100644
--- a/src/mainboard/msi/ms7260/mptable.c
+++ b/src/mainboard/msi/ms7260/mptable.c
@@ -44,7 +44,7 @@
 
 	/* I/O APICs: APIC ID	Version	State		Address */
 	{
-		device_t dev;
+		struct device *dev;
 		struct resource *res;
 		uint32_t dword;
 
diff --git a/src/mainboard/msi/ms7721/mainboard.c b/src/mainboard/msi/ms7721/mainboard.c
index 00d887f..09645f3 100644
--- a/src/mainboard/msi/ms7721/mainboard.c
+++ b/src/mainboard/msi/ms7721/mainboard.c
@@ -20,7 +20,7 @@
 /*************************************************
  * enable the dedicated function in thatcher board.
  *************************************************/
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
 {
 	msr_t msr;
 
diff --git a/src/mainboard/msi/ms7721/mptable.c b/src/mainboard/msi/ms7721/mptable.c
index 3135769..cf45d94 100644
--- a/src/mainboard/msi/ms7721/mptable.c
+++ b/src/mainboard/msi/ms7721/mptable.c
@@ -144,7 +144,7 @@
 	/* on board NIC & Slot PCIE.  */
 
 	/* PCI slots */
-	device_t dev = dev_find_slot(0, PCI_DEVFN(0x14, 4));
+	struct device *dev = dev_find_slot(0, PCI_DEVFN(0x14, 4));
 	if (dev && dev->enabled) {
 		u8 bus_pci = dev->link_list->secondary;
 		/* PCI_SLOT 0. */
diff --git a/src/mainboard/msi/ms9185/get_bus_conf.c b/src/mainboard/msi/ms9185/get_bus_conf.c
index 9fee211..d02f306 100644
--- a/src/mainboard/msi/ms9185/get_bus_conf.c
+++ b/src/mainboard/msi/ms9185/get_bus_conf.c
@@ -62,7 +62,7 @@
 
 	unsigned apicid_base;
 
-	device_t dev;
+	struct device *dev;
 	int i;
 	struct mb_sysconf_t *m;
 
diff --git a/src/mainboard/msi/ms9185/mptable.c b/src/mainboard/msi/ms9185/mptable.c
index 1e517a3..3e0241b 100644
--- a/src/mainboard/msi/ms9185/mptable.c
+++ b/src/mainboard/msi/ms9185/mptable.c
@@ -52,7 +52,7 @@
 
 /*I/O APICs:   APIC ID Version State           Address*/
 	{
-		device_t dev = 0;
+		struct device *dev = 0;
 		struct resource *res;
 		for (i = 0; i < 3; i++) {
 			dev = dev_find_device(0x1166, 0x0235, dev);
@@ -91,7 +91,7 @@
 	/* enable int */
 	/* why here? must get the BAR and PCI command bit 1 set before enable it ....*/
 	{
-		device_t dev;
+		struct device *dev;
 		dev = dev_find_device(0x1166, 0x0205, 0);
 		if (dev) {
 			uint32_t dword;
diff --git a/src/mainboard/msi/ms9282/get_bus_conf.c b/src/mainboard/msi/ms9282/get_bus_conf.c
index a2d3aef..a072d6a 100644
--- a/src/mainboard/msi/ms9282/get_bus_conf.c
+++ b/src/mainboard/msi/ms9282/get_bus_conf.c
@@ -64,7 +64,7 @@
 	unsigned apicid_base;
 	struct mb_sysconf_t *m;
 
-	device_t dev;
+	struct device *dev;
 	int i;
 
 	if (get_bus_conf_done == 1)
diff --git a/src/mainboard/msi/ms9282/mptable.c b/src/mainboard/msi/ms9282/mptable.c
index c53fe78..d3a4287 100644
--- a/src/mainboard/msi/ms9282/mptable.c
+++ b/src/mainboard/msi/ms9282/mptable.c
@@ -48,7 +48,7 @@
 
 /*I/O APICs:   APIC ID Version State	   Address*/
 	{
-		device_t dev;
+		struct device *dev;
 		struct resource *res;
 		uint32_t dword;
 
diff --git a/src/mainboard/msi/ms9652_fam10/acpi_tables.c b/src/mainboard/msi/ms9652_fam10/acpi_tables.c
index 7c86286..93abea4 100644
--- a/src/mainboard/msi/ms9652_fam10/acpi_tables.c
+++ b/src/mainboard/msi/ms9652_fam10/acpi_tables.c
@@ -39,7 +39,7 @@
 
 	unsigned sbdn;
 	struct resource *res;
-	device_t dev;
+	struct device *dev;
 
 	get_bus_conf();
 	sbdn = sysconf.sbdn;
diff --git a/src/mainboard/msi/ms9652_fam10/get_bus_conf.c b/src/mainboard/msi/ms9652_fam10/get_bus_conf.c
index 19f8d3b..c5ceb75 100644
--- a/src/mainboard/msi/ms9652_fam10/get_bus_conf.c
+++ b/src/mainboard/msi/ms9652_fam10/get_bus_conf.c
@@ -65,7 +65,7 @@
 	unsigned apicid_base;
 	struct mb_sysconf_t *m;
 
-	device_t dev;
+	struct device *dev;
 	int i;
 
 	printk(BIOS_SPEW, "get_bus_conf()\n");
diff --git a/src/mainboard/msi/ms9652_fam10/mptable.c b/src/mainboard/msi/ms9652_fam10/mptable.c
index 6adc53e..7115daf 100644
--- a/src/mainboard/msi/ms9652_fam10/mptable.c
+++ b/src/mainboard/msi/ms9652_fam10/mptable.c
@@ -45,7 +45,7 @@
 
 /*I/O APICs:	APIC ID	Version	State		Address*/
 	{
-		device_t dev;
+		struct device *dev;
 		struct resource *res;
 		uint32_t dword;
 

-- 
To view, visit https://review.coreboot.org/26102
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f29fe3b85bc56ff3f2d225822c415513e961459
Gerrit-Change-Number: 26102
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180504/861e1bd9/attachment.html>


More information about the coreboot-gerrit mailing list