<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26102">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/msi: Get rid of device_t<br><br>Use of device_t has been abandoned in ramstage.<br><br>Change-Id: I7f29fe3b85bc56ff3f2d225822c415513e961459<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/mainboard/msi/ms7135/acpi_tables.c<br>M src/mainboard/msi/ms7135/get_bus_conf.c<br>M src/mainboard/msi/ms7135/mptable.c<br>M src/mainboard/msi/ms7260/get_bus_conf.c<br>M src/mainboard/msi/ms7260/mptable.c<br>M src/mainboard/msi/ms7721/mainboard.c<br>M src/mainboard/msi/ms7721/mptable.c<br>M src/mainboard/msi/ms9185/get_bus_conf.c<br>M src/mainboard/msi/ms9185/mptable.c<br>M src/mainboard/msi/ms9282/get_bus_conf.c<br>M src/mainboard/msi/ms9282/mptable.c<br>M src/mainboard/msi/ms9652_fam10/acpi_tables.c<br>M src/mainboard/msi/ms9652_fam10/get_bus_conf.c<br>M src/mainboard/msi/ms9652_fam10/mptable.c<br>14 files changed, 15 insertions(+), 15 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/26102/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/msi/ms7135/acpi_tables.c b/src/mainboard/msi/ms7135/acpi_tables.c</span><br><span>index c7482e0..a637637 100644</span><br><span>--- a/src/mainboard/msi/ms7135/acpi_tables.c</span><br><span>+++ b/src/mainboard/msi/ms7135/acpi_tables.c</span><br><span>@@ -16,7 +16,7 @@</span><br><span> /* APIC */</span><br><span> unsigned long acpi_fill_madt(unsigned long current)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span> struct resource *res;</span><br><span> </span><br><span> /* create all subtables for processors */</span><br><span>diff --git a/src/mainboard/msi/ms7135/get_bus_conf.c b/src/mainboard/msi/ms7135/get_bus_conf.c</span><br><span>index 77b0b07..19b520f 100644</span><br><span>--- a/src/mainboard/msi/ms7135/get_bus_conf.c</span><br><span>+++ b/src/mainboard/msi/ms7135/get_bus_conf.c</span><br><span>@@ -49,7 +49,7 @@</span><br><span> {</span><br><span> unsigned apicid_base;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span> unsigned sbdn;</span><br><span> int i;</span><br><span> </span><br><span>diff --git a/src/mainboard/msi/ms7135/mptable.c b/src/mainboard/msi/ms7135/mptable.c</span><br><span>index f4c26ca..35dc02c 100644</span><br><span>--- a/src/mainboard/msi/ms7135/mptable.c</span><br><span>+++ b/src/mainboard/msi/ms7135/mptable.c</span><br><span>@@ -46,7 +46,7 @@</span><br><span> </span><br><span> /* I/O APICs: APIC ID Version State Address*/</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span> struct resource *res;</span><br><span> u32 dword;</span><br><span> </span><br><span>diff --git a/src/mainboard/msi/ms7260/get_bus_conf.c b/src/mainboard/msi/ms7260/get_bus_conf.c</span><br><span>index b1a03c1..d768041 100644</span><br><span>--- a/src/mainboard/msi/ms7260/get_bus_conf.c</span><br><span>+++ b/src/mainboard/msi/ms7260/get_bus_conf.c</span><br><span>@@ -63,7 +63,7 @@</span><br><span> void get_bus_conf(void)</span><br><span> {</span><br><span> unsigned int apicid_base, sbdn;</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span> int i;</span><br><span> </span><br><span> if (get_bus_conf_done == 1)</span><br><span>diff --git a/src/mainboard/msi/ms7260/mptable.c b/src/mainboard/msi/ms7260/mptable.c</span><br><span>index 2ba4af9..6450d2d 100644</span><br><span>--- a/src/mainboard/msi/ms7260/mptable.c</span><br><span>+++ b/src/mainboard/msi/ms7260/mptable.c</span><br><span>@@ -44,7 +44,7 @@</span><br><span> </span><br><span> /* I/O APICs: APIC ID Version State Address */</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span> struct resource *res;</span><br><span> uint32_t dword;</span><br><span> </span><br><span>diff --git a/src/mainboard/msi/ms7721/mainboard.c b/src/mainboard/msi/ms7721/mainboard.c</span><br><span>index 00d887f..09645f3 100644</span><br><span>--- a/src/mainboard/msi/ms7721/mainboard.c</span><br><span>+++ b/src/mainboard/msi/ms7721/mainboard.c</span><br><span>@@ -20,7 +20,7 @@</span><br><span> /*************************************************</span><br><span> * enable the dedicated function in thatcher board.</span><br><span> *************************************************/</span><br><span style="color: hsl(0, 100%, 40%);">-static void mainboard_enable(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void mainboard_enable(struct device *dev)</span><br><span> {</span><br><span> msr_t msr;</span><br><span> </span><br><span>diff --git a/src/mainboard/msi/ms7721/mptable.c b/src/mainboard/msi/ms7721/mptable.c</span><br><span>index 3135769..cf45d94 100644</span><br><span>--- a/src/mainboard/msi/ms7721/mptable.c</span><br><span>+++ b/src/mainboard/msi/ms7721/mptable.c</span><br><span>@@ -144,7 +144,7 @@</span><br><span> /* on board NIC & Slot PCIE. */</span><br><span> </span><br><span> /* PCI slots */</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev = dev_find_slot(0, PCI_DEVFN(0x14, 4));</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev = dev_find_slot(0, PCI_DEVFN(0x14, 4));</span><br><span> if (dev && dev->enabled) {</span><br><span> u8 bus_pci = dev->link_list->secondary;</span><br><span> /* PCI_SLOT 0. */</span><br><span>diff --git a/src/mainboard/msi/ms9185/get_bus_conf.c b/src/mainboard/msi/ms9185/get_bus_conf.c</span><br><span>index 9fee211..d02f306 100644</span><br><span>--- a/src/mainboard/msi/ms9185/get_bus_conf.c</span><br><span>+++ b/src/mainboard/msi/ms9185/get_bus_conf.c</span><br><span>@@ -62,7 +62,7 @@</span><br><span> </span><br><span> unsigned apicid_base;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span> int i;</span><br><span> struct mb_sysconf_t *m;</span><br><span> </span><br><span>diff --git a/src/mainboard/msi/ms9185/mptable.c b/src/mainboard/msi/ms9185/mptable.c</span><br><span>index 1e517a3..3e0241b 100644</span><br><span>--- a/src/mainboard/msi/ms9185/mptable.c</span><br><span>+++ b/src/mainboard/msi/ms9185/mptable.c</span><br><span>@@ -52,7 +52,7 @@</span><br><span> </span><br><span> /*I/O APICs: APIC ID Version State Address*/</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev = 0;</span><br><span> struct resource *res;</span><br><span> for (i = 0; i < 3; i++) {</span><br><span> dev = dev_find_device(0x1166, 0x0235, dev);</span><br><span>@@ -91,7 +91,7 @@</span><br><span> /* enable int */</span><br><span> /* why here? must get the BAR and PCI command bit 1 set before enable it ....*/</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span> dev = dev_find_device(0x1166, 0x0205, 0);</span><br><span> if (dev) {</span><br><span> uint32_t dword;</span><br><span>diff --git a/src/mainboard/msi/ms9282/get_bus_conf.c b/src/mainboard/msi/ms9282/get_bus_conf.c</span><br><span>index a2d3aef..a072d6a 100644</span><br><span>--- a/src/mainboard/msi/ms9282/get_bus_conf.c</span><br><span>+++ b/src/mainboard/msi/ms9282/get_bus_conf.c</span><br><span>@@ -64,7 +64,7 @@</span><br><span> unsigned apicid_base;</span><br><span> struct mb_sysconf_t *m;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span> int i;</span><br><span> </span><br><span> if (get_bus_conf_done == 1)</span><br><span>diff --git a/src/mainboard/msi/ms9282/mptable.c b/src/mainboard/msi/ms9282/mptable.c</span><br><span>index c53fe78..d3a4287 100644</span><br><span>--- a/src/mainboard/msi/ms9282/mptable.c</span><br><span>+++ b/src/mainboard/msi/ms9282/mptable.c</span><br><span>@@ -48,7 +48,7 @@</span><br><span> </span><br><span> /*I/O APICs: APIC ID Version State Address*/</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span> struct resource *res;</span><br><span> uint32_t dword;</span><br><span> </span><br><span>diff --git a/src/mainboard/msi/ms9652_fam10/acpi_tables.c b/src/mainboard/msi/ms9652_fam10/acpi_tables.c</span><br><span>index 7c86286..93abea4 100644</span><br><span>--- a/src/mainboard/msi/ms9652_fam10/acpi_tables.c</span><br><span>+++ b/src/mainboard/msi/ms9652_fam10/acpi_tables.c</span><br><span>@@ -39,7 +39,7 @@</span><br><span> </span><br><span> unsigned sbdn;</span><br><span> struct resource *res;</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span> </span><br><span> get_bus_conf();</span><br><span> sbdn = sysconf.sbdn;</span><br><span>diff --git a/src/mainboard/msi/ms9652_fam10/get_bus_conf.c b/src/mainboard/msi/ms9652_fam10/get_bus_conf.c</span><br><span>index 19f8d3b..c5ceb75 100644</span><br><span>--- a/src/mainboard/msi/ms9652_fam10/get_bus_conf.c</span><br><span>+++ b/src/mainboard/msi/ms9652_fam10/get_bus_conf.c</span><br><span>@@ -65,7 +65,7 @@</span><br><span> unsigned apicid_base;</span><br><span> struct mb_sysconf_t *m;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span> int i;</span><br><span> </span><br><span> printk(BIOS_SPEW, "get_bus_conf()\n");</span><br><span>diff --git a/src/mainboard/msi/ms9652_fam10/mptable.c b/src/mainboard/msi/ms9652_fam10/mptable.c</span><br><span>index 6adc53e..7115daf 100644</span><br><span>--- a/src/mainboard/msi/ms9652_fam10/mptable.c</span><br><span>+++ b/src/mainboard/msi/ms9652_fam10/mptable.c</span><br><span>@@ -45,7 +45,7 @@</span><br><span> </span><br><span> /*I/O APICs: APIC ID Version State Address*/</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span> struct resource *res;</span><br><span> uint32_t dword;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26102">change 26102</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26102"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7f29fe3b85bc56ff3f2d225822c415513e961459 </div>
<div style="display:none"> Gerrit-Change-Number: 26102 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>