[coreboot-gerrit] Change in coreboot[master]: mb/hp: Get rid of device_t

Elyes HAOUAS (Code Review) gerrit at coreboot.org
Fri May 4 20:43:07 CEST 2018


Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26087


Change subject: mb/hp: Get rid of device_t
......................................................................

mb/hp: Get rid of device_t

Use of device_t has been abandoned in ramstage.

Change-Id: Ib9c0d0a85a9e38cdb1bdbcfa055e597f19cf3d5c
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/mainboard/hp/2570p/mainboard.c
M src/mainboard/hp/2760p/mainboard.c
M src/mainboard/hp/8460p/mainboard.c
M src/mainboard/hp/8470p/mainboard.c
M src/mainboard/hp/abm/mainboard.c
M src/mainboard/hp/abm/mptable.c
M src/mainboard/hp/dl145_g1/acpi_tables.c
M src/mainboard/hp/dl145_g1/get_bus_conf.c
M src/mainboard/hp/dl145_g1/mptable.c
M src/mainboard/hp/dl145_g3/get_bus_conf.c
M src/mainboard/hp/dl145_g3/mptable.c
M src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c
M src/mainboard/hp/dl165_g6_fam10/mptable.c
M src/mainboard/hp/folio_9470m/mainboard.c
M src/mainboard/hp/pavilion_m6_1035dx/mainboard.c
M src/mainboard/hp/pavilion_m6_1035dx/mptable.c
M src/mainboard/hp/revolve_810_g1/mainboard.c
17 files changed, 23 insertions(+), 23 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/26087/1

diff --git a/src/mainboard/hp/2570p/mainboard.c b/src/mainboard/hp/2570p/mainboard.c
index b5fdecc..effba5e 100644
--- a/src/mainboard/hp/2570p/mainboard.c
+++ b/src/mainboard/hp/2570p/mainboard.c
@@ -16,7 +16,7 @@
 #include <device/device.h>
 #include <drivers/intel/gma/int15.h>
 
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
 {
 	install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
 			GMA_INT15_PANEL_FIT_DEFAULT,
diff --git a/src/mainboard/hp/2760p/mainboard.c b/src/mainboard/hp/2760p/mainboard.c
index b5fdecc..effba5e 100644
--- a/src/mainboard/hp/2760p/mainboard.c
+++ b/src/mainboard/hp/2760p/mainboard.c
@@ -16,7 +16,7 @@
 #include <device/device.h>
 #include <drivers/intel/gma/int15.h>
 
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
 {
 	install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
 			GMA_INT15_PANEL_FIT_DEFAULT,
diff --git a/src/mainboard/hp/8460p/mainboard.c b/src/mainboard/hp/8460p/mainboard.c
index b5fdecc..effba5e 100644
--- a/src/mainboard/hp/8460p/mainboard.c
+++ b/src/mainboard/hp/8460p/mainboard.c
@@ -16,7 +16,7 @@
 #include <device/device.h>
 #include <drivers/intel/gma/int15.h>
 
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
 {
 	install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
 			GMA_INT15_PANEL_FIT_DEFAULT,
diff --git a/src/mainboard/hp/8470p/mainboard.c b/src/mainboard/hp/8470p/mainboard.c
index b5fdecc..effba5e 100644
--- a/src/mainboard/hp/8470p/mainboard.c
+++ b/src/mainboard/hp/8470p/mainboard.c
@@ -16,7 +16,7 @@
 #include <device/device.h>
 #include <drivers/intel/gma/int15.h>
 
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
 {
 	install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
 			GMA_INT15_PANEL_FIT_DEFAULT,
diff --git a/src/mainboard/hp/abm/mainboard.c b/src/mainboard/hp/abm/mainboard.c
index 09fbf37..aaa899b 100644
--- a/src/mainboard/hp/abm/mainboard.c
+++ b/src/mainboard/hp/abm/mainboard.c
@@ -92,7 +92,7 @@
 /**********************************************
  * Enable the dedicated functions of the board.
  **********************************************/
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
 {
 	printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
 
diff --git a/src/mainboard/hp/abm/mptable.c b/src/mainboard/hp/abm/mptable.c
index 6869519..cf987ca 100644
--- a/src/mainboard/hp/abm/mptable.c
+++ b/src/mainboard/hp/abm/mptable.c
@@ -178,7 +178,7 @@
 	/* on board NIC & Slot PCIE.  */
 
 	/* PCI slots */
-	device_t dev = dev_find_slot(0, PCI_DEVFN(0x14, 4));
+	struct device *dev = dev_find_slot(0, PCI_DEVFN(0x14, 4));
 	if (dev && dev->enabled) {
 		u8 bus_pci = dev->link_list->secondary;
 		/* PCI_SLOT 0. */
diff --git a/src/mainboard/hp/dl145_g1/acpi_tables.c b/src/mainboard/hp/dl145_g1/acpi_tables.c
index ca6cea0..a464678 100644
--- a/src/mainboard/hp/dl145_g1/acpi_tables.c
+++ b/src/mainboard/hp/dl145_g1/acpi_tables.c
@@ -40,7 +40,7 @@
 
 	/* Write all 8131 IOAPICs */
 	{
-		device_t dev;
+		struct device *dev;
 		struct resource *res;
 		dev = dev_find_slot(m->bus_8131_0, PCI_DEVFN((sysconf.hcdn[0]&0xff), 1));
 		if (dev) {
diff --git a/src/mainboard/hp/dl145_g1/get_bus_conf.c b/src/mainboard/hp/dl145_g1/get_bus_conf.c
index 7a9e3b5..ef76824 100644
--- a/src/mainboard/hp/dl145_g1/get_bus_conf.c
+++ b/src/mainboard/hp/dl145_g1/get_bus_conf.c
@@ -49,7 +49,7 @@
 
 	unsigned apicid_base;
 
-	device_t dev;
+	struct device *dev;
 	int i;
 
 	if (get_bus_conf_done == 1)
diff --git a/src/mainboard/hp/dl145_g1/mptable.c b/src/mainboard/hp/dl145_g1/mptable.c
index 1a9132e..80ad79d 100644
--- a/src/mainboard/hp/dl145_g1/mptable.c
+++ b/src/mainboard/hp/dl145_g1/mptable.c
@@ -31,7 +31,7 @@
 /*I/O APICs:	APIC ID	Version	State		Address*/
 	smp_write_ioapic(mc, m->apicid_8111, 0x20, VIO_APIC_VADDR);
 	{
-		device_t dev;
+		struct device *dev;
 		struct resource *res;
 		dev = dev_find_slot(m->bus_8131_0, PCI_DEVFN(m->sbdn3,1));
 		if (dev) {
diff --git a/src/mainboard/hp/dl145_g3/get_bus_conf.c b/src/mainboard/hp/dl145_g3/get_bus_conf.c
index 15a7466..fc9c104 100644
--- a/src/mainboard/hp/dl145_g3/get_bus_conf.c
+++ b/src/mainboard/hp/dl145_g3/get_bus_conf.c
@@ -64,7 +64,7 @@
 
 	unsigned apicid_base;
 
-	device_t dev;
+	struct device *dev;
 	int i;
 	struct mb_sysconf_t *m;
 
diff --git a/src/mainboard/hp/dl145_g3/mptable.c b/src/mainboard/hp/dl145_g3/mptable.c
index 4e33f9b..dea286a 100644
--- a/src/mainboard/hp/dl145_g3/mptable.c
+++ b/src/mainboard/hp/dl145_g3/mptable.c
@@ -54,7 +54,7 @@
 
 	/*I/O APICs:   APIC ID Version State           Address*/
 	{
-		device_t dev = 0;
+		struct device *dev = 0;
 		int i;
 		struct resource *res;
 		for (i = 0; i < 3; i++) {
@@ -87,7 +87,7 @@
 	outb(0x0e, 0x4d1);
 
 	{
-		device_t dev;
+		struct device *dev;
 		dev = dev_find_device(0x1166, 0x0205, 0);
 		if(dev) {
 			uint32_t dword;
@@ -103,7 +103,7 @@
 
 	// hide XIOAPIC PCI configuration space
 	{
-		device_t dev;
+		struct device *dev;
 		dev = dev_find_device(0x1166, 0x205, 0);
 		if (dev) {
 			uint32_t dword;
@@ -148,7 +148,7 @@
 	/* enable int */
 	/* why here? must get the BAR and PCI command bit 1 set before enable it ....*/
 	{
-		device_t dev;
+		struct device *dev;
 		dev = dev_find_device(0x1166, 0x0205, 0);
 		if(dev) {
 			uint32_t dword;
diff --git a/src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c b/src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c
index 84c7c9b..b29fb2c 100644
--- a/src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c
+++ b/src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c
@@ -65,7 +65,7 @@
 
 	unsigned apicid_base;
 
-	device_t dev;
+	struct device *dev;
 	int i;
 	struct mb_sysconf_t *m;
 
diff --git a/src/mainboard/hp/dl165_g6_fam10/mptable.c b/src/mainboard/hp/dl165_g6_fam10/mptable.c
index 6a27d97..5cd6212 100644
--- a/src/mainboard/hp/dl165_g6_fam10/mptable.c
+++ b/src/mainboard/hp/dl165_g6_fam10/mptable.c
@@ -55,7 +55,7 @@
 
 	/*I/O APICs:   APIC ID Version State           Address*/
 	{
-		device_t dev = 0;
+		struct device *dev = 0;
 		int i;
 		struct resource *res;
 		for (i = 0; i < 3; i++) {
@@ -84,7 +84,7 @@
 	outb(0x0e, 0x4d1);
 
 	{
-		device_t dev;
+		struct device *dev;
 		dev = dev_find_device(0x1166, 0x0205, 0);
 		if (dev) {
 			uint32_t dword;
@@ -100,7 +100,7 @@
 
 	// hide XIOAPIC PCI configuration space
 	{
-		device_t dev;
+		struct device *dev;
 		dev = dev_find_device(0x1166, 0x205, 0);
 		if (dev) {
 			uint32_t dword;
@@ -127,7 +127,7 @@
 	/* enable int */
 	/* why here? must get the BAR and PCI command bit 1 set before enable it ....*/
 	{
-		device_t dev;
+		struct device *dev;
 		dev = dev_find_device(0x1166, 0x0205, 0);
 		if (dev) {
 			uint32_t dword;
diff --git a/src/mainboard/hp/folio_9470m/mainboard.c b/src/mainboard/hp/folio_9470m/mainboard.c
index 437a7ca..058701e 100644
--- a/src/mainboard/hp/folio_9470m/mainboard.c
+++ b/src/mainboard/hp/folio_9470m/mainboard.c
@@ -16,7 +16,7 @@
 #include <device/device.h>
 #include <drivers/intel/gma/int15.h>
 
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
 {
 	install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
 			GMA_INT15_PANEL_FIT_DEFAULT,
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/mainboard.c b/src/mainboard/hp/pavilion_m6_1035dx/mainboard.c
index de84dbe..d7f0771 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/mainboard.c
+++ b/src/mainboard/hp/pavilion_m6_1035dx/mainboard.c
@@ -30,7 +30,7 @@
 	pavilion_m6_1035dx_ec_init();
 }
 
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
 {
 	printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
 
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/mptable.c b/src/mainboard/hp/pavilion_m6_1035dx/mptable.c
index 39af326..a78c82e 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/mptable.c
+++ b/src/mainboard/hp/pavilion_m6_1035dx/mptable.c
@@ -145,7 +145,7 @@
 	/* on board NIC & Slot PCIE.  */
 
 	/* PCI slots */
-	device_t dev = dev_find_slot(0, PCI_DEVFN(0x14, 4));
+	struct device *dev = dev_find_slot(0, PCI_DEVFN(0x14, 4));
 	if (dev && dev->enabled) {
 		u8 bus_pci = dev->link_list->secondary;
 		/* PCI_SLOT 0. */
diff --git a/src/mainboard/hp/revolve_810_g1/mainboard.c b/src/mainboard/hp/revolve_810_g1/mainboard.c
index e9228c1..48ffce5 100644
--- a/src/mainboard/hp/revolve_810_g1/mainboard.c
+++ b/src/mainboard/hp/revolve_810_g1/mainboard.c
@@ -16,7 +16,7 @@
 #include <device/device.h>
 #include <drivers/intel/gma/int15.h>
 
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
 {
 	install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
 			GMA_INT15_PANEL_FIT_DEFAULT,

-- 
To view, visit https://review.coreboot.org/26087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9c0d0a85a9e38cdb1bdbcfa055e597f19cf3d5c
Gerrit-Change-Number: 26087
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180504/ce5eca18/attachment-0001.html>


More information about the coreboot-gerrit mailing list