<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26087">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/hp: Get rid of device_t<br><br>Use of device_t has been abandoned in ramstage.<br><br>Change-Id: Ib9c0d0a85a9e38cdb1bdbcfa055e597f19cf3d5c<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/mainboard/hp/2570p/mainboard.c<br>M src/mainboard/hp/2760p/mainboard.c<br>M src/mainboard/hp/8460p/mainboard.c<br>M src/mainboard/hp/8470p/mainboard.c<br>M src/mainboard/hp/abm/mainboard.c<br>M src/mainboard/hp/abm/mptable.c<br>M src/mainboard/hp/dl145_g1/acpi_tables.c<br>M src/mainboard/hp/dl145_g1/get_bus_conf.c<br>M src/mainboard/hp/dl145_g1/mptable.c<br>M src/mainboard/hp/dl145_g3/get_bus_conf.c<br>M src/mainboard/hp/dl145_g3/mptable.c<br>M src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c<br>M src/mainboard/hp/dl165_g6_fam10/mptable.c<br>M src/mainboard/hp/folio_9470m/mainboard.c<br>M src/mainboard/hp/pavilion_m6_1035dx/mainboard.c<br>M src/mainboard/hp/pavilion_m6_1035dx/mptable.c<br>M src/mainboard/hp/revolve_810_g1/mainboard.c<br>17 files changed, 23 insertions(+), 23 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/26087/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/hp/2570p/mainboard.c b/src/mainboard/hp/2570p/mainboard.c</span><br><span>index b5fdecc..effba5e 100644</span><br><span>--- a/src/mainboard/hp/2570p/mainboard.c</span><br><span>+++ b/src/mainboard/hp/2570p/mainboard.c</span><br><span>@@ -16,7 +16,7 @@</span><br><span> #include <device/device.h></span><br><span> #include <drivers/intel/gma/int15.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void mainboard_enable(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void mainboard_enable(struct device *dev)</span><br><span> {</span><br><span>       install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,</span><br><span>                       GMA_INT15_PANEL_FIT_DEFAULT,</span><br><span>diff --git a/src/mainboard/hp/2760p/mainboard.c b/src/mainboard/hp/2760p/mainboard.c</span><br><span>index b5fdecc..effba5e 100644</span><br><span>--- a/src/mainboard/hp/2760p/mainboard.c</span><br><span>+++ b/src/mainboard/hp/2760p/mainboard.c</span><br><span>@@ -16,7 +16,7 @@</span><br><span> #include <device/device.h></span><br><span> #include <drivers/intel/gma/int15.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void mainboard_enable(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void mainboard_enable(struct device *dev)</span><br><span> {</span><br><span>         install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,</span><br><span>                       GMA_INT15_PANEL_FIT_DEFAULT,</span><br><span>diff --git a/src/mainboard/hp/8460p/mainboard.c b/src/mainboard/hp/8460p/mainboard.c</span><br><span>index b5fdecc..effba5e 100644</span><br><span>--- a/src/mainboard/hp/8460p/mainboard.c</span><br><span>+++ b/src/mainboard/hp/8460p/mainboard.c</span><br><span>@@ -16,7 +16,7 @@</span><br><span> #include <device/device.h></span><br><span> #include <drivers/intel/gma/int15.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void mainboard_enable(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void mainboard_enable(struct device *dev)</span><br><span> {</span><br><span>         install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,</span><br><span>                       GMA_INT15_PANEL_FIT_DEFAULT,</span><br><span>diff --git a/src/mainboard/hp/8470p/mainboard.c b/src/mainboard/hp/8470p/mainboard.c</span><br><span>index b5fdecc..effba5e 100644</span><br><span>--- a/src/mainboard/hp/8470p/mainboard.c</span><br><span>+++ b/src/mainboard/hp/8470p/mainboard.c</span><br><span>@@ -16,7 +16,7 @@</span><br><span> #include <device/device.h></span><br><span> #include <drivers/intel/gma/int15.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void mainboard_enable(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void mainboard_enable(struct device *dev)</span><br><span> {</span><br><span>         install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,</span><br><span>                       GMA_INT15_PANEL_FIT_DEFAULT,</span><br><span>diff --git a/src/mainboard/hp/abm/mainboard.c b/src/mainboard/hp/abm/mainboard.c</span><br><span>index 09fbf37..aaa899b 100644</span><br><span>--- a/src/mainboard/hp/abm/mainboard.c</span><br><span>+++ b/src/mainboard/hp/abm/mainboard.c</span><br><span>@@ -92,7 +92,7 @@</span><br><span> /**********************************************</span><br><span>  * Enable the dedicated functions of the board.</span><br><span>  **********************************************/</span><br><span style="color: hsl(0, 100%, 40%);">-static void mainboard_enable(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void mainboard_enable(struct device *dev)</span><br><span> {</span><br><span>     printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");</span><br><span> </span><br><span>diff --git a/src/mainboard/hp/abm/mptable.c b/src/mainboard/hp/abm/mptable.c</span><br><span>index 6869519..cf987ca 100644</span><br><span>--- a/src/mainboard/hp/abm/mptable.c</span><br><span>+++ b/src/mainboard/hp/abm/mptable.c</span><br><span>@@ -178,7 +178,7 @@</span><br><span>        /* on board NIC & Slot PCIE.  */</span><br><span> </span><br><span>     /* PCI slots */</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev = dev_find_slot(0, PCI_DEVFN(0x14, 4));</span><br><span style="color: hsl(120, 100%, 40%);">+  struct device *dev = dev_find_slot(0, PCI_DEVFN(0x14, 4));</span><br><span>   if (dev && dev->enabled) {</span><br><span>                u8 bus_pci = dev->link_list->secondary;</span><br><span>                /* PCI_SLOT 0. */</span><br><span>diff --git a/src/mainboard/hp/dl145_g1/acpi_tables.c b/src/mainboard/hp/dl145_g1/acpi_tables.c</span><br><span>index ca6cea0..a464678 100644</span><br><span>--- a/src/mainboard/hp/dl145_g1/acpi_tables.c</span><br><span>+++ b/src/mainboard/hp/dl145_g1/acpi_tables.c</span><br><span>@@ -40,7 +40,7 @@</span><br><span> </span><br><span>   /* Write all 8131 IOAPICs */</span><br><span>         {</span><br><span style="color: hsl(0, 100%, 40%);">-               device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+         struct device *dev;</span><br><span>          struct resource *res;</span><br><span>                dev = dev_find_slot(m->bus_8131_0, PCI_DEVFN((sysconf.hcdn[0]&0xff), 1));</span><br><span>             if (dev) {</span><br><span>diff --git a/src/mainboard/hp/dl145_g1/get_bus_conf.c b/src/mainboard/hp/dl145_g1/get_bus_conf.c</span><br><span>index 7a9e3b5..ef76824 100644</span><br><span>--- a/src/mainboard/hp/dl145_g1/get_bus_conf.c</span><br><span>+++ b/src/mainboard/hp/dl145_g1/get_bus_conf.c</span><br><span>@@ -49,7 +49,7 @@</span><br><span> </span><br><span>      unsigned apicid_base;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span>  int i;</span><br><span> </span><br><span>   if (get_bus_conf_done == 1)</span><br><span>diff --git a/src/mainboard/hp/dl145_g1/mptable.c b/src/mainboard/hp/dl145_g1/mptable.c</span><br><span>index 1a9132e..80ad79d 100644</span><br><span>--- a/src/mainboard/hp/dl145_g1/mptable.c</span><br><span>+++ b/src/mainboard/hp/dl145_g1/mptable.c</span><br><span>@@ -31,7 +31,7 @@</span><br><span> /*I/O APICs:        APIC ID Version State           Address*/</span><br><span>    smp_write_ioapic(mc, m->apicid_8111, 0x20, VIO_APIC_VADDR);</span><br><span>       {</span><br><span style="color: hsl(0, 100%, 40%);">-               device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+         struct device *dev;</span><br><span>          struct resource *res;</span><br><span>                dev = dev_find_slot(m->bus_8131_0, PCI_DEVFN(m->sbdn3,1));</span><br><span>             if (dev) {</span><br><span>diff --git a/src/mainboard/hp/dl145_g3/get_bus_conf.c b/src/mainboard/hp/dl145_g3/get_bus_conf.c</span><br><span>index 15a7466..fc9c104 100644</span><br><span>--- a/src/mainboard/hp/dl145_g3/get_bus_conf.c</span><br><span>+++ b/src/mainboard/hp/dl145_g3/get_bus_conf.c</span><br><span>@@ -64,7 +64,7 @@</span><br><span> </span><br><span>      unsigned apicid_base;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span>  int i;</span><br><span>       struct mb_sysconf_t *m;</span><br><span> </span><br><span>diff --git a/src/mainboard/hp/dl145_g3/mptable.c b/src/mainboard/hp/dl145_g3/mptable.c</span><br><span>index 4e33f9b..dea286a 100644</span><br><span>--- a/src/mainboard/hp/dl145_g3/mptable.c</span><br><span>+++ b/src/mainboard/hp/dl145_g3/mptable.c</span><br><span>@@ -54,7 +54,7 @@</span><br><span> </span><br><span>         /*I/O APICs:   APIC ID Version State           Address*/</span><br><span>     {</span><br><span style="color: hsl(0, 100%, 40%);">-               device_t dev = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+             struct device *dev = 0;</span><br><span>              int i;</span><br><span>               struct resource *res;</span><br><span>                for (i = 0; i < 3; i++) {</span><br><span>@@ -87,7 +87,7 @@</span><br><span>     outb(0x0e, 0x4d1);</span><br><span> </span><br><span>       {</span><br><span style="color: hsl(0, 100%, 40%);">-               device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+         struct device *dev;</span><br><span>          dev = dev_find_device(0x1166, 0x0205, 0);</span><br><span>            if(dev) {</span><br><span>                    uint32_t dword;</span><br><span>@@ -103,7 +103,7 @@</span><br><span> </span><br><span>    // hide XIOAPIC PCI configuration space</span><br><span>      {</span><br><span style="color: hsl(0, 100%, 40%);">-               device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+         struct device *dev;</span><br><span>          dev = dev_find_device(0x1166, 0x205, 0);</span><br><span>             if (dev) {</span><br><span>                   uint32_t dword;</span><br><span>@@ -148,7 +148,7 @@</span><br><span>        /* enable int */</span><br><span>     /* why here? must get the BAR and PCI command bit 1 set before enable it ....*/</span><br><span>      {</span><br><span style="color: hsl(0, 100%, 40%);">-               device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+         struct device *dev;</span><br><span>          dev = dev_find_device(0x1166, 0x0205, 0);</span><br><span>            if(dev) {</span><br><span>                    uint32_t dword;</span><br><span>diff --git a/src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c b/src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c</span><br><span>index 84c7c9b..b29fb2c 100644</span><br><span>--- a/src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c</span><br><span>+++ b/src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c</span><br><span>@@ -65,7 +65,7 @@</span><br><span> </span><br><span>         unsigned apicid_base;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span>  int i;</span><br><span>       struct mb_sysconf_t *m;</span><br><span> </span><br><span>diff --git a/src/mainboard/hp/dl165_g6_fam10/mptable.c b/src/mainboard/hp/dl165_g6_fam10/mptable.c</span><br><span>index 6a27d97..5cd6212 100644</span><br><span>--- a/src/mainboard/hp/dl165_g6_fam10/mptable.c</span><br><span>+++ b/src/mainboard/hp/dl165_g6_fam10/mptable.c</span><br><span>@@ -55,7 +55,7 @@</span><br><span> </span><br><span>         /*I/O APICs:   APIC ID Version State           Address*/</span><br><span>     {</span><br><span style="color: hsl(0, 100%, 40%);">-               device_t dev = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+             struct device *dev = 0;</span><br><span>              int i;</span><br><span>               struct resource *res;</span><br><span>                for (i = 0; i < 3; i++) {</span><br><span>@@ -84,7 +84,7 @@</span><br><span>     outb(0x0e, 0x4d1);</span><br><span> </span><br><span>       {</span><br><span style="color: hsl(0, 100%, 40%);">-               device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+         struct device *dev;</span><br><span>          dev = dev_find_device(0x1166, 0x0205, 0);</span><br><span>            if (dev) {</span><br><span>                   uint32_t dword;</span><br><span>@@ -100,7 +100,7 @@</span><br><span> </span><br><span>    // hide XIOAPIC PCI configuration space</span><br><span>      {</span><br><span style="color: hsl(0, 100%, 40%);">-               device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+         struct device *dev;</span><br><span>          dev = dev_find_device(0x1166, 0x205, 0);</span><br><span>             if (dev) {</span><br><span>                   uint32_t dword;</span><br><span>@@ -127,7 +127,7 @@</span><br><span>        /* enable int */</span><br><span>     /* why here? must get the BAR and PCI command bit 1 set before enable it ....*/</span><br><span>      {</span><br><span style="color: hsl(0, 100%, 40%);">-               device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+         struct device *dev;</span><br><span>          dev = dev_find_device(0x1166, 0x0205, 0);</span><br><span>            if (dev) {</span><br><span>                   uint32_t dword;</span><br><span>diff --git a/src/mainboard/hp/folio_9470m/mainboard.c b/src/mainboard/hp/folio_9470m/mainboard.c</span><br><span>index 437a7ca..058701e 100644</span><br><span>--- a/src/mainboard/hp/folio_9470m/mainboard.c</span><br><span>+++ b/src/mainboard/hp/folio_9470m/mainboard.c</span><br><span>@@ -16,7 +16,7 @@</span><br><span> #include <device/device.h></span><br><span> #include <drivers/intel/gma/int15.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void mainboard_enable(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void mainboard_enable(struct device *dev)</span><br><span> {</span><br><span>      install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,</span><br><span>                       GMA_INT15_PANEL_FIT_DEFAULT,</span><br><span>diff --git a/src/mainboard/hp/pavilion_m6_1035dx/mainboard.c b/src/mainboard/hp/pavilion_m6_1035dx/mainboard.c</span><br><span>index de84dbe..d7f0771 100644</span><br><span>--- a/src/mainboard/hp/pavilion_m6_1035dx/mainboard.c</span><br><span>+++ b/src/mainboard/hp/pavilion_m6_1035dx/mainboard.c</span><br><span>@@ -30,7 +30,7 @@</span><br><span>    pavilion_m6_1035dx_ec_init();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void mainboard_enable(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void mainboard_enable(struct device *dev)</span><br><span> {</span><br><span>      printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");</span><br><span> </span><br><span>diff --git a/src/mainboard/hp/pavilion_m6_1035dx/mptable.c b/src/mainboard/hp/pavilion_m6_1035dx/mptable.c</span><br><span>index 39af326..a78c82e 100644</span><br><span>--- a/src/mainboard/hp/pavilion_m6_1035dx/mptable.c</span><br><span>+++ b/src/mainboard/hp/pavilion_m6_1035dx/mptable.c</span><br><span>@@ -145,7 +145,7 @@</span><br><span>    /* on board NIC & Slot PCIE.  */</span><br><span> </span><br><span>     /* PCI slots */</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev = dev_find_slot(0, PCI_DEVFN(0x14, 4));</span><br><span style="color: hsl(120, 100%, 40%);">+  struct device *dev = dev_find_slot(0, PCI_DEVFN(0x14, 4));</span><br><span>   if (dev && dev->enabled) {</span><br><span>                u8 bus_pci = dev->link_list->secondary;</span><br><span>                /* PCI_SLOT 0. */</span><br><span>diff --git a/src/mainboard/hp/revolve_810_g1/mainboard.c b/src/mainboard/hp/revolve_810_g1/mainboard.c</span><br><span>index e9228c1..48ffce5 100644</span><br><span>--- a/src/mainboard/hp/revolve_810_g1/mainboard.c</span><br><span>+++ b/src/mainboard/hp/revolve_810_g1/mainboard.c</span><br><span>@@ -16,7 +16,7 @@</span><br><span> #include <device/device.h></span><br><span> #include <drivers/intel/gma/int15.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void mainboard_enable(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void mainboard_enable(struct device *dev)</span><br><span> {</span><br><span>        install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,</span><br><span>                       GMA_INT15_PANEL_FIT_DEFAULT,</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26087">change 26087</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26087"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib9c0d0a85a9e38cdb1bdbcfa055e597f19cf3d5c </div>
<div style="display:none"> Gerrit-Change-Number: 26087 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>