[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Use common lockdown code

Maulik V Vaghela (Code Review) gerrit at coreboot.org
Thu May 3 13:25:35 CEST 2018


Maulik V Vaghela has uploaded a new patch set (#2). ( https://review.coreboot.org/26032 )

Change subject: soc/intel/skylake: Use common lockdown code
......................................................................

soc/intel/skylake: Use common lockdown code

In previous patch, lockdown code has been added as part of common base
code and this code support is common across multiple SOCs. Skylake can
also use same common code instead of keeping redundant copy inside soc
folder. So removing lockdown.c from skylake folder and instead using
common lockdown code.

We need to implement soc specific function for skylake which returns soc
specific lockdown configuration to common code. This function has been
implemented inside chip.c and chip_fsp20.c files

BUG=none
BRANCH=none
TEST= code compiles with different configurations. No changes in code
logic.

Change-Id: I462ccf02424f6734cf6fb505eaf7ce6dcd2833d5
Signed-off-by: Maulik V Vaghela <maulik.v.vaghela at intel.com>
---
M src/soc/intel/skylake/Kconfig
M src/soc/intel/skylake/Makefile.inc
M src/soc/intel/skylake/chip.c
M src/soc/intel/skylake/chip_fsp20.c
D src/soc/intel/skylake/lockdown.c
5 files changed, 43 insertions(+), 114 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/26032/2
-- 
To view, visit https://review.coreboot.org/26032
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I462ccf02424f6734cf6fb505eaf7ce6dcd2833d5
Gerrit-Change-Number: 26032
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180503/81e1ebec/attachment.html>


More information about the coreboot-gerrit mailing list