[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: Invert polarity of EMR_GARAGE_DET#

[Shelley Chen (Code Review)]

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/26017


Change subject: mb/google/poppy/variants/nami: Invert polarity of EMR_GARAGE_DET#
......................................................................

mb/google/poppy/variants/nami: Invert polarity of EMR_GARAGE_DET#

This gpio should be active low, but it not currently configured that way.
Changing gpio configuration to reflect that.

BUG=b:73121017
BRANCH=None
TEST=iotools mmio_read32 0xfdae0588 (GPP_E1)
     Make sure that when pen is ejected, gpio is low
     and when pen is inserted, gpio is high

Change-Id: Ic49eea6412c3378dca39a3338b43df12bc27037d
Signed-off-by: Shelley Chen <shchen at google.com>
---
M src/mainboard/google/poppy/variants/nami/gpio.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/26017/1

diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c
index 927a530..6398d2d 100644
--- a/src/mainboard/google/poppy/variants/nami/gpio.c
+++ b/src/mainboard/google/poppy/variants/nami/gpio.c
@@ -210,8 +210,8 @@
 
 	/* E0  : SATAXPCI0 ==> H1_PCH_INT_ODL */
 	PAD_CFG_GPI_APIC_INVERT(GPP_E0, NONE, PLTRST),
-	/* E1  : SATAXPCIE1 ==> PEN_EJECT_ODL - for wake event */
-	PAD_CFG_GPI_ACPI_SCI(GPP_E1, NONE, DEEP, NONE),
+	/* E1  : SATAXPCIE1 ==> EMR_GARAGE_DET# - for wake event */
+	PAD_CFG_GPI_ACPI_SCI(GPP_E1, NONE, DEEP, INVERT),
 	/* E2  : SATAXPCIE2 ==> WLAN_OFF# */
 	PAD_CFG_GPO(GPP_E2, 1, DEEP),
 	/* E3  : CPU_GP0 ==> TRACKPAD_INT# */
@@ -224,7 +224,7 @@
 	PAD_CFG_NC(GPP_E6),
 	/* E7  : CPU_GP1 ==> TOUCHSCREEN_INT# */
 	PAD_CFG_GPI_APIC(GPP_E7, NONE, PLTRST),
-	/* E8  : SATALED# ==> PEN_EJECT_ODL - for notification */
+	/* E8  : SATALED# ==> EMR_GARAGE_DET# - for notification */
 	PAD_CFG_GPI_GPIO_DRIVER(GPP_E8, NONE, DEEP),
 	/* E9  : USB2_OCO# ==> USB_C0_OC# */
 	PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1),

-- 
To view, visit https://review.coreboot.org/26017
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic49eea6412c3378dca39a3338b43df12bc27037d
Gerrit-Change-Number: 26017
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180502/09f212e5/attachment.html>