<p>Shelley Chen has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26017">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nami: Invert polarity of EMR_GARAGE_DET#<br><br>This gpio should be active low, but it not currently configured that way.<br>Changing gpio configuration to reflect that.<br><br>BUG=b:73121017<br>BRANCH=None<br>TEST=iotools mmio_read32 0xfdae0588 (GPP_E1)<br>     Make sure that when pen is ejected, gpio is low<br>     and when pen is inserted, gpio is high<br><br>Change-Id: Ic49eea6412c3378dca39a3338b43df12bc27037d<br>Signed-off-by: Shelley Chen <shchen@google.com><br>---<br>M src/mainboard/google/poppy/variants/nami/gpio.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/26017/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c</span><br><span>index 927a530..6398d2d 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nami/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nami/gpio.c</span><br><span>@@ -210,8 +210,8 @@</span><br><span> </span><br><span>         /* E0  : SATAXPCI0 ==> H1_PCH_INT_ODL */</span><br><span>  PAD_CFG_GPI_APIC_INVERT(GPP_E0, NONE, PLTRST),</span><br><span style="color: hsl(0, 100%, 40%);">-  /* E1  : SATAXPCIE1 ==> PEN_EJECT_ODL - for wake event */</span><br><span style="color: hsl(0, 100%, 40%);">-    PAD_CFG_GPI_ACPI_SCI(GPP_E1, NONE, DEEP, NONE),</span><br><span style="color: hsl(120, 100%, 40%);">+       /* E1  : SATAXPCIE1 ==> EMR_GARAGE_DET# - for wake event */</span><br><span style="color: hsl(120, 100%, 40%);">+        PAD_CFG_GPI_ACPI_SCI(GPP_E1, NONE, DEEP, INVERT),</span><br><span>    /* E2  : SATAXPCIE2 ==> WLAN_OFF# */</span><br><span>      PAD_CFG_GPO(GPP_E2, 1, DEEP),</span><br><span>        /* E3  : CPU_GP0 ==> TRACKPAD_INT# */</span><br><span>@@ -224,7 +224,7 @@</span><br><span>       PAD_CFG_NC(GPP_E6),</span><br><span>  /* E7  : CPU_GP1 ==> TOUCHSCREEN_INT# */</span><br><span>  PAD_CFG_GPI_APIC(GPP_E7, NONE, PLTRST),</span><br><span style="color: hsl(0, 100%, 40%);">- /* E8  : SATALED# ==> PEN_EJECT_ODL - for notification */</span><br><span style="color: hsl(120, 100%, 40%);">+  /* E8  : SATALED# ==> EMR_GARAGE_DET# - for notification */</span><br><span>       PAD_CFG_GPI_GPIO_DRIVER(GPP_E8, NONE, DEEP),</span><br><span>         /* E9  : USB2_OCO# ==> USB_C0_OC# */</span><br><span>      PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1),</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26017">change 26017</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26017"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic49eea6412c3378dca39a3338b43df12bc27037d </div>
<div style="display:none"> Gerrit-Change-Number: 26017 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Shelley Chen <shchen@google.com> </div>