[coreboot-gerrit] Change in coreboot[master]: mainboard/google/reef: Remove tablet mode switch support

Martin Roth (Code Review) gerrit at coreboot.org
Wed May 2 04:53:07 CEST 2018


Martin Roth has uploaded this change for review. ( https://review.coreboot.org/25982


Change subject: mainboard/google/reef: Remove tablet mode switch support
......................................................................

mainboard/google/reef: Remove tablet mode switch support

The _SB.DPTF.TPET ACPI code attached to EC_ENABLE_TABLET_EVENT doesn't
exist in the apollo lake code.  Remove it from reef as part of the
cleanup to update to the new version of IASL.

This was in commit 4f803ac28f4 (mainboards/google/reef: Add support for
tablet mode switch.)

Change-Id: Ic10c418ddc708c1aed87ad4a9861f04d32445116
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
1 file changed, 1 insertion(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/25982/1

diff --git a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
index ff32ff6..ec18d62 100644
--- a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
@@ -33,8 +33,7 @@
 	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\
 	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER)       |\
 	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP)              |\
-	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU)            |\
-	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE))
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU))
 
 #define MAINBOARD_EC_SMI_EVENTS \
 	(EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED))
@@ -71,9 +70,6 @@
 #define EC_ENABLE_LID_SWITCH
 #define EC_ENABLE_WAKE_PIN	GPE_EC_WAKE
 
-/* Enable Tablet switch */
-#define EC_ENABLE_TABLET_EVENT
-
 #define EC_ENABLE_TBMC_DEVICE
 
 #define SIO_EC_MEMMAP_ENABLE     /* EC Memory Map Resources */

-- 
To view, visit https://review.coreboot.org/25982
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic10c418ddc708c1aed87ad4a9861f04d32445116
Gerrit-Change-Number: 25982
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180502/3fefe0df/attachment.html>


More information about the coreboot-gerrit mailing list