<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25982">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/reef: Remove tablet mode switch support<br><br>The _SB.DPTF.TPET ACPI code attached to EC_ENABLE_TABLET_EVENT doesn't<br>exist in the apollo lake code.  Remove it from reef as part of the<br>cleanup to update to the new version of IASL.<br><br>This was in commit 4f803ac28f4 (mainboards/google/reef: Add support for<br>tablet mode switch.)<br><br>Change-Id: Ic10c418ddc708c1aed87ad4a9861f04d32445116<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h<br>1 file changed, 1 insertion(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/25982/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h</span><br><span>index ff32ff6..ec18d62 100644</span><br><span>--- a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h</span><br><span>+++ b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h</span><br><span>@@ -33,8 +33,7 @@</span><br><span>     EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\</span><br><span>       EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER)       |\</span><br><span>       EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP)              |\</span><br><span style="color: hsl(0, 100%, 40%);">-  EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU)            |\</span><br><span style="color: hsl(0, 100%, 40%);">-  EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE))</span><br><span style="color: hsl(120, 100%, 40%);">+        EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU))</span><br><span> </span><br><span> #define MAINBOARD_EC_SMI_EVENTS \</span><br><span>  (EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED))</span><br><span>@@ -71,9 +70,6 @@</span><br><span> #define EC_ENABLE_LID_SWITCH</span><br><span> #define EC_ENABLE_WAKE_PIN        GPE_EC_WAKE</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Enable Tablet switch */</span><br><span style="color: hsl(0, 100%, 40%);">-#define EC_ENABLE_TABLET_EVENT</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #define EC_ENABLE_TBMC_DEVICE</span><br><span> </span><br><span> #define SIO_EC_MEMMAP_ENABLE     /* EC Memory Map Resources */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25982">change 25982</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25982"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic10c418ddc708c1aed87ad4a9861f04d32445116 </div>
<div style="display:none"> Gerrit-Change-Number: 25982 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>