[coreboot-gerrit] Change in coreboot[master]: chromeec: fix an uninitialized local variable

[Zhuohao Lee (Code Review)]

Zhuohao Lee has uploaded this change for review. ( https://review.coreboot.org/25460


Change subject: chromeec: fix an uninitialized local variable
......................................................................

chromeec: fix an uninitialized local variable

google_chromeec_command() may only write the 1 or 2 bytes to
variable r (4 bytes). However, this api returns 4 bytes data.
To avaid returning the error data, we need to initialize the
local variable.

BUG=b:76442548
BRANCH=none
TEST=write 2 bytes data into the flash,
     then, use cbi_get_uint32 read data back.

Change-Id: I3395c97ab6bfd7882d7728310de8a29041190e76
Signed-off-by: Zhuohao Lee <zhuohao at chromium.org>
---
M src/ec/google/chromeec/ec.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/25460/1

diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c
index efe22e2..fb3ffab 100644
--- a/src/ec/google/chromeec/ec.c
+++ b/src/ec/google/chromeec/ec.c
@@ -563,7 +563,7 @@
 {
 	struct chromeec_command cmd;
 	struct ec_params_get_cbi p;
-	uint32_t r;
+	uint32_t r = 0;
 	int rv;
 
 	p.type = type;

-- 
To view, visit https://review.coreboot.org/25460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3395c97ab6bfd7882d7728310de8a29041190e76
Gerrit-Change-Number: 25460
Gerrit-PatchSet: 1
Gerrit-Owner: Zhuohao Lee <zhuohao at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180330/9196c1d8/attachment-0001.html>