<p>Zhuohao Lee has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25460">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">chromeec: fix an uninitialized local variable<br><br>google_chromeec_command() may only write the 1 or 2 bytes to<br>variable r (4 bytes). However, this api returns 4 bytes data.<br>To avaid returning the error data, we need to initialize the<br>local variable.<br><br>BUG=b:76442548<br>BRANCH=none<br>TEST=write 2 bytes data into the flash,<br>     then, use cbi_get_uint32 read data back.<br><br>Change-Id: I3395c97ab6bfd7882d7728310de8a29041190e76<br>Signed-off-by: Zhuohao Lee <zhuohao@chromium.org><br>---<br>M src/ec/google/chromeec/ec.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/25460/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c</span><br><span>index efe22e2..fb3ffab 100644</span><br><span>--- a/src/ec/google/chromeec/ec.c</span><br><span>+++ b/src/ec/google/chromeec/ec.c</span><br><span>@@ -563,7 +563,7 @@</span><br><span> {</span><br><span>       struct chromeec_command cmd;</span><br><span>         struct ec_params_get_cbi p;</span><br><span style="color: hsl(0, 100%, 40%);">-     uint32_t r;</span><br><span style="color: hsl(120, 100%, 40%);">+   uint32_t r = 0;</span><br><span>      int rv;</span><br><span> </span><br><span>  p.type = type;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25460">change 25460</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25460"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3395c97ab6bfd7882d7728310de8a29041190e76 </div>
<div style="display:none"> Gerrit-Change-Number: 25460 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Zhuohao Lee <zhuohao@chromium.org> </div>