[coreboot-gerrit] Change in coreboot[master]: util/intelmetool: Add additional helpful error messages

[Patrick Rudolph (Code Review)]

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/25401


Change subject: util/intelmetool: Add additional helpful error messages
......................................................................

util/intelmetool: Add additional helpful error messages

Add more verbose error message for common problems on modern
operating systems, like Secure Boot and CONFIG_STRICT_DEVMEM.

Change-Id: Ie3361910d48271bcc2cd3b4b74937fbc5df0a176
Signed-off-by: Patrick Rudolph <patrick.rudolph at 9elements.com>
---
M util/intelmetool/intelmetool.c
M util/intelmetool/rcba.c
2 files changed, 6 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/25401/1

diff --git a/util/intelmetool/intelmetool.c b/util/intelmetool/intelmetool.c
index b87a53b..0e75a50 100644
--- a/util/intelmetool/intelmetool.c
+++ b/util/intelmetool/intelmetool.c
@@ -490,7 +490,8 @@
 	#ifndef __DARWIN__
 		fd_mem = open("/dev/mem", O_RDWR);
 		if (fd_mem < 0) {
-			perror("Can not open /dev/mem");
+			perror("Can not open /dev/mem. Do you have disabled "
+			       "Secure Boot ?");
 			exit(1);
 		}
 
diff --git a/util/intelmetool/rcba.c b/util/intelmetool/rcba.c
index c138e89..ee43e65 100644
--- a/util/intelmetool/rcba.c
+++ b/util/intelmetool/rcba.c
@@ -68,7 +68,8 @@
 
 	rcba = map_physical((off_t)rcba_phys, size);
 	if (rcba == NULL) {
-		printf("Could not map RCBA\n");
+		printf("Could not map RCBA\n"
+		       "Do you have cmdline argument 'iomem=relaxed' set ?\n");
 		return 1;
 	}
 	*(uint32_t *)(rcba + addr) = val;
@@ -93,7 +94,8 @@
 
 	rcba = map_physical((off_t)rcba_phys, size);
 	if (rcba == NULL) {
-		printf("Could not map RCBA\n");
+		printf("Could not map RCBA\n"
+		       "Do you have cmdline argument 'iomem=relaxed' set ?\n");
 		return 1;
 	}
 

-- 
To view, visit https://review.coreboot.org/25401
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3361910d48271bcc2cd3b4b74937fbc5df0a176
Gerrit-Change-Number: 25401
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180328/1f548202/attachment-0001.html>