<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25401">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/intelmetool: Add additional helpful error messages<br><br>Add more verbose error message for common problems on modern<br>operating systems, like Secure Boot and CONFIG_STRICT_DEVMEM.<br><br>Change-Id: Ie3361910d48271bcc2cd3b4b74937fbc5df0a176<br>Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com><br>---<br>M util/intelmetool/intelmetool.c<br>M util/intelmetool/rcba.c<br>2 files changed, 6 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/25401/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/intelmetool/intelmetool.c b/util/intelmetool/intelmetool.c</span><br><span>index b87a53b..0e75a50 100644</span><br><span>--- a/util/intelmetool/intelmetool.c</span><br><span>+++ b/util/intelmetool/intelmetool.c</span><br><span>@@ -490,7 +490,8 @@</span><br><span>  #ifndef __DARWIN__</span><br><span>           fd_mem = open("/dev/mem", O_RDWR);</span><br><span>                 if (fd_mem < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-                    perror("Can not open /dev/mem");</span><br><span style="color: hsl(120, 100%, 40%);">+                    perror("Can not open /dev/mem. Do you have disabled "</span><br><span style="color: hsl(120, 100%, 40%);">+                              "Secure Boot ?");</span><br><span>                   exit(1);</span><br><span>             }</span><br><span> </span><br><span>diff --git a/util/intelmetool/rcba.c b/util/intelmetool/rcba.c</span><br><span>index c138e89..ee43e65 100644</span><br><span>--- a/util/intelmetool/rcba.c</span><br><span>+++ b/util/intelmetool/rcba.c</span><br><span>@@ -68,7 +68,8 @@</span><br><span> </span><br><span>       rcba = map_physical((off_t)rcba_phys, size);</span><br><span>         if (rcba == NULL) {</span><br><span style="color: hsl(0, 100%, 40%);">-             printf("Could not map RCBA\n");</span><br><span style="color: hsl(120, 100%, 40%);">+             printf("Could not map RCBA\n"</span><br><span style="color: hsl(120, 100%, 40%);">+                      "Do you have cmdline argument 'iomem=relaxed' set ?\n");</span><br><span>            return 1;</span><br><span>    }</span><br><span>    *(uint32_t *)(rcba + addr) = val;</span><br><span>@@ -93,7 +94,8 @@</span><br><span> </span><br><span>    rcba = map_physical((off_t)rcba_phys, size);</span><br><span>         if (rcba == NULL) {</span><br><span style="color: hsl(0, 100%, 40%);">-             printf("Could not map RCBA\n");</span><br><span style="color: hsl(120, 100%, 40%);">+             printf("Could not map RCBA\n"</span><br><span style="color: hsl(120, 100%, 40%);">+                      "Do you have cmdline argument 'iomem=relaxed' set ?\n");</span><br><span>            return 1;</span><br><span>    }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25401">change 25401</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25401"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ie3361910d48271bcc2cd3b4b74937fbc5df0a176 </div>
<div style="display:none"> Gerrit-Change-Number: 25401 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> </div>