[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Remove emmc tuning parameters from devicetree

Furquan Shaikh (Code Review) gerrit at coreboot.org
Tue Mar 27 01:45:31 CEST 2018


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/25375


Change subject: mb/google/octopus: Remove emmc tuning parameters from devicetree
......................................................................

mb/google/octopus: Remove emmc tuning parameters from devicetree

Current emmc tuning parameters for octopus were copied over from other
boards and result in failure to boot from emmc. This change gets rid
of the emmc tuning parameters in devicetree. Once emmc tuning tests
are run for octopus, these parameters can be added back.

BUG=b:75986903
BRANCH=None
TEST=Verified that octopus boots from eMMC without any errors in
depthcharge.

Change-Id: I7ac44a54afd1ecfe355a9654ac8e92133b67637f
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/octopus/variants/baseboard/devicetree.cb
1 file changed, 0 insertions(+), 42 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/25375/1

diff --git a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb
index a19d247..7aa7038 100644
--- a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb
@@ -24,48 +24,6 @@
 	# GPIO for PERST_0 (WLAN_PE_RST)
 	register "prt0_gpio" = "GPIO_164"
 
-	# EMMC TX DATA Delay 1
-	# Refer to EDS-Vol2-16.33.
-	# [14:8] steps of delay for HS400, each 125ps.
-	# [6:0] steps of delay for SDR104/HS200, each 125ps.
-	register "emmc_tx_data_cntl1" = "0x0C3A"
-
-	# EMMC TX DATA Delay 2
-	# Refer to EDS-Vol2-16.34.
-	# [30:24] steps of delay for SDR50, each 125ps.
-	# [22:16] steps of delay for DDR50, each 125ps.
-	# [14:8] steps of delay for SDR25/HS50, each 125ps.
-	# [6:0] steps of delay for SDR12, each 125ps.
-	register "emmc_tx_data_cntl2" = "0x28272929"
-
-	# EMMC RX CMD/DATA Delay 1
-	# Refer to EDS-Vol2-16.35.
-	# [30:24] steps of delay for SDR50, each 125ps.
-	# [22:16] steps of delay for DDR50, each 125ps.
-	# [14:8] steps of delay for SDR25/HS50, each 125ps.
-	# [6:0] steps of delay for SDR12, each 125ps.
-	register "emmc_rx_cmd_data_cntl1" = "0x003B263B"
-
-	# EMMC RX CMD/DATA Delay 2
-	# Refer to EDS-Vol2-16.37.
-	# [17:16] stands for Rx Clock before Output Buffer
-	# [14:8] steps of delay for Auto Tuning Mode, each 125ps.
-	# [6:0] steps of delay for HS200, each 125ps.
-	register "emmc_rx_cmd_data_cntl2" = "0x10008"
-
-	# EMMC RX STROBE Delay
-	# Refer to EDS-Vol2-16.36.
-	# [16] Enable Auto Tuning for HS400 Strobe Path
-	# [14:8] steps of delay for HS400 Mode 1, each 125ps.
-	# [6:0] steps of delay for HS400 Mode 2, each 125ps.
-	register "emmc_rx_strobe_cntl" = "0x0a0a"
-
-	# EMMC TX COMMAND Delay
-	# Refer to EDS-Vol2-16.32.
-	# [14:8] steps of delay for DDR Mode, each 125ps.
-	# [6:0] steps of delay for SDR Mode, each 125ps.
-	register "emmc_tx_cmd_cntl" = "0x1305"
-
 	# GPE configuration
 	# Note that GPE events called out in ASL code rely on this
 	# route, i.e., if this route changes then the affected GPE

-- 
To view, visit https://review.coreboot.org/25375
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ac44a54afd1ecfe355a9654ac8e92133b67637f
Gerrit-Change-Number: 25375
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180326/80578149/attachment.html>


More information about the coreboot-gerrit mailing list