[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/nautilus: Turn off MIPI camera in PMOF methos

Seunghwan Kim (Code Review) gerrit at coreboot.org
Fri Mar 23 09:26:27 CET 2018


Seunghwan Kim has uploaded this change for review. ( https://review.coreboot.org/25337


Change subject: mb/google/poppy/variant/nautilus: Turn off MIPI camera in PMOF methos
......................................................................

mb/google/poppy/variant/nautilus: Turn off MIPI camera in PMOF methos

This change remove work-around code for the power issue of MIPI and
USB cameras on previous board revision. With the work-around code,
PMOF ACPI methos cannot turn off MIPI camera. So we need to remove
it.

BUG=b:74214248
BRANCH=poppy
TEST=emerge-nautilus coreboot

Change-Id: I7becaf61de364f82976ec0be7f8c9e4ef1a7aedd
Signed-off-by: Seunghwan Kim <sh_.kim at samsung.com>
---
M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
1 file changed, 0 insertions(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/25337/1

diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
index b74fba9..5eaf5b7 100644
--- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
@@ -39,14 +39,7 @@
 		Method (PMOF, 0, Serialized) {
 			/* Make Sure all PMIC outputs are off. */
 			If (LEqual (VSIC, Zero)) {
-			/*
-			 * On Nautilus Pre-EVT/EVT, the USB and MIPI share the
-			 * same power source, before HW fix in DVT, temporarily
-			 * disabled turn off 3V3_VDD
-			 */
-#if !IS_ENABLED(CONFIG_BOARD_GOOGLE_NAUTILUS)
 				CTXS(EN_PP3300_DX_CAM)
-#endif
 			}
 		}
 

-- 
To view, visit https://review.coreboot.org/25337
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7becaf61de364f82976ec0be7f8c9e4ef1a7aedd
Gerrit-Change-Number: 25337
Gerrit-PatchSet: 1
Gerrit-Owner: Seunghwan Kim <sh_.kim at samsung.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180323/1f39497c/attachment.html>


More information about the coreboot-gerrit mailing list