<p>Seunghwan Kim has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25337">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variant/nautilus: Turn off MIPI camera in PMOF methos<br><br>This change remove work-around code for the power issue of MIPI and<br>USB cameras on previous board revision. With the work-around code,<br>PMOF ACPI methos cannot turn off MIPI camera. So we need to remove<br>it.<br><br>BUG=b:74214248<br>BRANCH=poppy<br>TEST=emerge-nautilus coreboot<br><br>Change-Id: I7becaf61de364f82976ec0be7f8c9e4ef1a7aedd<br>Signed-off-by: Seunghwan Kim <sh_.kim@samsung.com><br>---<br>M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl<br>1 file changed, 0 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/25337/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl</span><br><span>index b74fba9..5eaf5b7 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl</span><br><span>+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl</span><br><span>@@ -39,14 +39,7 @@</span><br><span>             Method (PMOF, 0, Serialized) {</span><br><span>                       /* Make Sure all PMIC outputs are off. */</span><br><span>                    If (LEqual (VSIC, Zero)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                      /*</span><br><span style="color: hsl(0, 100%, 40%);">-                       * On Nautilus Pre-EVT/EVT, the USB and MIPI share the</span><br><span style="color: hsl(0, 100%, 40%);">-                   * same power source, before HW fix in DVT, temporarily</span><br><span style="color: hsl(0, 100%, 40%);">-                  * disabled turn off 3V3_VDD</span><br><span style="color: hsl(0, 100%, 40%);">-                     */</span><br><span style="color: hsl(0, 100%, 40%);">-#if !IS_ENABLED(CONFIG_BOARD_GOOGLE_NAUTILUS)</span><br><span>                             CTXS(EN_PP3300_DX_CAM)</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span>                         }</span><br><span>            }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25337">change 25337</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25337"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7becaf61de364f82976ec0be7f8c9e4ef1a7aedd </div>
<div style="display:none"> Gerrit-Change-Number: 25337 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Seunghwan Kim <sh_.kim@samsung.com> </div>