[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Turn off FSP's deassertion of PERST# signal.

Shamile Khan (Code Review) gerrit at coreboot.org
Thu Mar 22 01:15:40 CET 2018


Shamile Khan has uploaded this change for review. ( https://review.coreboot.org/25311


Change subject: soc/intel/apollolake: Turn off FSP's deassertion of PERST# signal.
......................................................................

soc/intel/apollolake: Turn off FSP's deassertion of PERST# signal.

BUG=b:76058338
BRANCH=None
TEST=Build coreboot for Octopus board.

Change-Id: I1858c7843d16b6b63fc30762a889916bbb9b781a
Signed-off-by: Shamile Khan <shamile.khan at intel.com>
---
M src/soc/intel/apollolake/chip.c
1 file changed, 11 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/25311/1

diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index cac2f11..88044d3 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -513,6 +513,17 @@
 	memcpy(silconfig->PcieRpSelectableDeemphasis,
 		cfg->pcie_rp_deemphasis_enable,
 		sizeof(silconfig->PcieRpSelectableDeemphasis));
+
+	/* FSP performs a PERST# signal deassertion for PCIe ports with
+	 * the GPIO address specified in these UPDs. Over-ride the default
+	 * addresses with 0 to turn off PERST# signal deassertion.   
+	 */
+	silconfig->RootPort0Perst = 0;
+	silconfig->RootPort1Perst = 0;
+	silconfig->RootPort2Perst = 0;
+	silconfig->RootPort3Perst = 0;
+	silconfig->RootPort4Perst = 0;
+	silconfig->RootPort5Perst = 0;
 }
 
 void __attribute__((weak)) mainboard_devtree_update(struct device *dev)

-- 
To view, visit https://review.coreboot.org/25311
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1858c7843d16b6b63fc30762a889916bbb9b781a
Gerrit-Change-Number: 25311
Gerrit-PatchSet: 1
Gerrit-Owner: Shamile Khan <shamile.khan at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180322/e50b42d9/attachment-0001.html>


More information about the coreboot-gerrit mailing list