[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Initialize EC earlier in the bootblock
Martin Roth (Code Review)
gerrit at coreboot.org
Mon Mar 19 23:47:04 CET 2018
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/25286
Change subject: mainboard/google/kahlee: Initialize EC earlier in the bootblock
......................................................................
mainboard/google/kahlee: Initialize EC earlier in the bootblock
Set up the EC communication a little earlier so we can read the board
ID before programming GPIOS.
BUG=b:73078053
TEST=Build & Boot grunt, board_id() now gets ID correctly
Change-Id: Icf3f598824cfed69fa03ba2bb86503bb3c3699a5
Signed-off-by: Martin Roth <martinroth at chromium.org>
---
M src/mainboard/google/kahlee/bootblock/bootblock.c
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/25286/1
diff --git a/src/mainboard/google/kahlee/bootblock/bootblock.c b/src/mainboard/google/kahlee/bootblock/bootblock.c
index acdffe5..1eb18f1 100644
--- a/src/mainboard/google/kahlee/bootblock/bootblock.c
+++ b/src/mainboard/google/kahlee/bootblock/bootblock.c
@@ -24,15 +24,16 @@
{
size_t num_gpios;
const struct soc_amd_stoneyridge_gpio *gpios;
+
+ /* Enable the EC as soon as we have visibility */
+ mainboard_ec_init();
+
gpios = variant_early_gpio_table(&num_gpios);
sb_program_gpios(gpios, num_gpios);
}
void bootblock_mainboard_init(void)
{
- /* Enable the EC as soon as we have visibility */
- mainboard_ec_init();
-
/* Setup TPM decode before verstage */
sb_tpm_decode_spi();
--
To view, visit https://review.coreboot.org/25286
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf3f598824cfed69fa03ba2bb86503bb3c3699a5
Gerrit-Change-Number: 25286
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180319/8952e346/attachment-0001.html>
More information about the coreboot-gerrit
mailing list