<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25286">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/kahlee: Initialize EC earlier in the bootblock<br><br>Set up the EC communication a little earlier so we can read the board<br>ID before programming GPIOS.<br><br>BUG=b:73078053<br>TEST=Build & Boot grunt, board_id() now gets ID correctly<br><br>Change-Id: Icf3f598824cfed69fa03ba2bb86503bb3c3699a5<br>Signed-off-by: Martin Roth <martinroth@chromium.org><br>---<br>M src/mainboard/google/kahlee/bootblock/bootblock.c<br>1 file changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/25286/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/bootblock/bootblock.c b/src/mainboard/google/kahlee/bootblock/bootblock.c</span><br><span>index acdffe5..1eb18f1 100644</span><br><span>--- a/src/mainboard/google/kahlee/bootblock/bootblock.c</span><br><span>+++ b/src/mainboard/google/kahlee/bootblock/bootblock.c</span><br><span>@@ -24,15 +24,16 @@</span><br><span> {</span><br><span>       size_t num_gpios;</span><br><span>    const struct soc_amd_stoneyridge_gpio *gpios;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+       /* Enable the EC as soon as we have visibility */</span><br><span style="color: hsl(120, 100%, 40%);">+     mainboard_ec_init();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>       gpios = variant_early_gpio_table(&num_gpios);</span><br><span>    sb_program_gpios(gpios, num_gpios);</span><br><span> }</span><br><span> </span><br><span> void bootblock_mainboard_init(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-        /* Enable the EC as soon as we have visibility */</span><br><span style="color: hsl(0, 100%, 40%);">-       mainboard_ec_init();</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>         /* Setup TPM decode before verstage */</span><br><span>       sb_tpm_decode_spi();</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25286">change 25286</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25286"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Icf3f598824cfed69fa03ba2bb86503bb3c3699a5 </div>
<div style="display:none"> Gerrit-Change-Number: 25286 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>