[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: Add gpio-keys ACPI node for PENH

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/25162 )

Change subject: mb/google/poppy/variants/nami: Add gpio-keys ACPI node for PENH
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants/nami/devicetree.cb
File src/mainboard/google/poppy/variants/nami/devicetree.cb:

https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants/nami/devicetree.cb@281
PS1, Line 281: 				register "generic.disable_gpio_export_in_crs" = "1"
register "generic.wake" = "GPE0_DW2_01"


https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants/nami/gpio.c
File src/mainboard/google/poppy/variants/nami/gpio.c:

https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants/nami/gpio.c@215
PS1, Line 215: PAD_CFG_GPI_GPIO_DRIVER
This should be ACPI_SCI


https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants/nami/gpio.c@229
PS1, Line 229: ACPI_SCI
and this should be GPIO_DRIVER



-- 
To view, visit https://review.coreboot.org/25162
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d87d938ac3a4e52e676850b9d8b80e83726275d
Gerrit-Change-Number: 25162
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 15 Mar 2018 00:30:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180315/e4e703dd/attachment.html>